1006343 - Cannot enable layouts with keyboard setup menu after 3rd-party keyboard installation

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

STR
===
1. Install "LOL keyboard" from marketplace.
2. After installation is complete, the system should pop up setup menu.
3. Enable "\o/" layout.
4. Launch the keyboard via any input field.

Expected result:
  The new layout has been enabled and ready to use. 
Actual:
  Could not see the new layout enabled.

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Since this is also a functional regression, nominate it as 2.0+.

Comment 2

[(not reading bugmail) Nick Desaulniers [:\n]]

Hey guys, is this blocking all third party keyboard support?

Comment 3

[(not reading bugmail) Nick Desaulniers [:\n]]

Looks like you can still enable by going through settings > keyboards etc. Just the prompt doesn't change the active keyboard.

Comment 4

[Pi Wei Cheng [:piwei] (inactive)]

Tested with Buri. This issue is reproducible on today's master, and reproducible on today's 1.4, but on today's 1.3, the keyboard cannot be successfully installed. After tapping on 'Install' on marketplace, the device does nothing, and in Settings it doesn't look like it's been installed either.

So I went back to:
20131212040203 master build - can't install keyboard
20131220040201 master build - can't install keyboard
20131230040201 master build - issue reproduces
20140112040202 master build - issue reproduces

My question is:
Is this really a regression?

Comment 5

[Jason Smith [:jsmith]]

The feature is disabled on 1.3 & 1.4, so that's why this isn't working there. The window needs to be analyzed on trunk here, as that's the only place where the feature was enabled.

Comment 6

[Pi Wei Cheng [:piwei] (inactive)]

If I understand correctly, I will be looking for a window between can't install & broken installation on master?

Comment 7

[Jason Smith [:jsmith]]

(In reply to Pi Wei Cheng from comment #6)
> If I understand correctly, I will be looking for a window between can't
> install & broken installation on master?

Nope - you should be looking for a window when this was last working on master, first broken on master.

Comment 8

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: Bug_1006343_QA_Window_Worksheet

(In reply to Jason Smith [:jsmith] from comment #7)
> Nope - you should be looking for a window when this was last working on
> master, first broken on master.

My testing shows that this has never worked. Attaching a txt worksheet of all the builds I went through and their results.

JZimbrick wants me to find the window between "Last Can't Install" and "First Broken Installation" anyway. So here it is.

b2g-inbound window:

Last Can't Install Environmental Variables:
Device: Buri MOZ
BuildID: 20140318202202
Gaia: 854f8d91d77fb1364683bf909f7605c185043c8e
Gecko: 38a3545c5a6c
Version: 31.0a1
Firmware Version: v1.2-device.cfg

First Broken Installation Environmental Variables:
Device: Buri MOZ
BuildID: 20140319000201
Gaia: db2ef2b61c70889533a0837fa3e053d24e95fdea
Gecko: a6476baa3307
Version: 31.0a1
Firmware Version: v1.2-device.cfg

Last Can't Install Gaia / First Broken Installation Gecko: Can't Install Keyboard
Gaia: 854f8d91d77fb1364683bf909f7605c185043c8e
Gecko: a6476baa3307

Last Can't Install Gecko / First Broken Installation Gaia: Issue DOES reproduce
Gaia: db2ef2b61c70889533a0837fa3e053d24e95fdea
Gecko: 38a3545c5a6c

Gaia Pushlog:
https://github.com/mozilla-b2g/gaia/compare/854f8d91d77fb1364683bf909f7605c185043c8e...db2ef2b61c70889533a0837fa3e053d24e95fdea

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch V1 - pull request 19199

This change make the IME install page invoke keyboard helper with manifestURL instead of app origin to enable a specific layout.
Unit test is also updated.

--
Gary, could you review this?
Thanks.

Comment 10

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Comment on attachment 8421834 [details] [review]
Patch V1 - pull request 19199

looks good for me, r=garychen.
Thanks~

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/00809a04b5ec88d0c97d725fdeeba7e3833177de

--
Gary, thanks for the review.

Comment 12

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

We don't have integration test yet to cover this feature, and will track this work with bug 1010021.

Comment 13

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Has been covered by the test added in bug 1010021.