1010021 - Add integration test to cover 3rd-party IME installation

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

+++ This bug was initially created as a clone of Bug #1006343 +++

This should cover,
 1. 3rd-party IME installation flow.
 2. 3rd-party IME setup menu - to enable layouts in the IME app.

Comment 1

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Hi Rudy,
   Can we duplicate with bug 928811?
   In my recall, we need APP intsall helper to dispatch 'install', 'unstall', 'update' event for  integration test.
   So maybe we can change the bug's title for tracking this issue?

   Any idea?

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Gary, 

Thanks.

Just change bug 928811 to a meta bug to cover all 3rd-party IME related test.
And we're going to try bug 1010029, so that we could have app installation related events triggered.

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch V1 - pull request 19363

1. Use a fake http server to serve the manifest file as a new keyboard app.
2. The app installed here is just a web app, which is required for triggering app installation flow here.
   And we have a hack to change the type from web app to "privileged" so that IME layout selection dialog will pop up (this is because input method API would only be exposed to privileged app).

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8424644 [details] [review]
Patch V1 - pull request 19363

This test has passed on travis.

Evan,

Could you please help review this?
Thank you.

Comment 5

[Evan Tseng [:evanxd]]

Hi Rudy,

Sure.

Could you cherry-pick this patch https://github.com/evanxd/gaia/commit/e91fa72917fe4bf1598a43b57f39e4ff2f1e5bba for running tests for 102 times(please give the travis job here), and we could check the stability. If all tests work well, then we could start to review the patch.

Thanks.

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Thanks for the remiding, just sent another pr to do the stability check,
https://github.com/mozilla-b2g/gaia/pull/19406

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Evan, it is all green for stability check,
https://travis-ci.org/mozilla-b2g/gaia/builds/25569308

Thanks.

Comment 8

[Evan Tseng [:evanxd]]

Comment on attachment 8424644 [details] [review]
Patch V1 - pull request 19363

Hi Rudy,
I added comments for the patch.

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8424644 [details] [review]
Patch V1 - pull request 19363

Patch updated to address all the review comments.

Evan, could you please help to review it again?
Thank you.

Comment 10

[Evan Tseng [:evanxd]]

Comment on attachment 8424644 [details] [review]
Patch V1 - pull request 19363

Hi Rudy,

I added comments for the patch.

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8424644 [details] [review]
Patch V1 - pull request 19363

Patch updated again.

Evan, please help review it again.
Thanks for your patience.

Comment 12

[Evan Tseng [:evanxd]]

Comment on attachment 8424644 [details] [review]
Patch V1 - pull request 19363

Hi Rudy,
Good works!

Comment 13

[Evan Tseng [:evanxd]]

master: aeaa7d2265d56ce3e45c5870a0d0d732e2447eb2