Closed
Bug 1006394
Opened 11 years ago
Closed 10 years ago
Test installing apps from the webapp runtime
Categories
(Firefox Graveyard :: Webapp Runtime, defect, P1)
Firefox Graveyard
Webapp Runtime
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 35
People
(Reporter: marco, Assigned: marco)
References
Details
Attachments
(1 file, 2 obsolete files)
3.87 KB,
patch
|
marco
:
review+
|
Details | Diff | Splinter Review |
We should write a webapprt chrome test for installing apps from the webapp runtime.
I have a WIP patch, it is working but there's a problem.
A TypeError exception ("this.Components is undefined") is thrown in specialpowersAPI.js (at http://hg.mozilla.org/mozilla-central/annotate/ab6426d96c6d/testing/specialpowers/content/specialpowersAPI.js#l625) when Webapps.js is firing the install success event (at http://hg.mozilla.org/mozilla-central/annotate/8e54082157d0/dom/apps/src/Webapps.js#l47).
Updated•11 years ago
|
Priority: -- → P1
Assignee | ||
Comment 1•10 years ago
|
||
I've written a basic test for this to at least cover the most important code paths.
Attachment #8499299 -
Flags: review?(myk)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8499299 -
Attachment is obsolete: true
Attachment #8499299 -
Flags: review?(myk)
Attachment #8499301 -
Flags: review?(myk)
Updated•10 years ago
|
Attachment #8499301 -
Flags: review?(myk) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Fixed commit message.
Assignee: nobody → mar.castelluccio
Attachment #8499301 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8502970 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 5•10 years ago
|
||
Keywords: checkin-needed
Comment 6•10 years ago
|
||
Comment 7•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•