Closed Bug 1006394 Opened 6 years ago Closed 5 years ago

Test installing apps from the webapp runtime

Categories

(Firefox Graveyard :: Webapp Runtime, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 35

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(1 file, 2 obsolete files)

We should write a webapprt chrome test for installing apps from the webapp runtime.

I have a WIP patch, it is working but there's a problem.
A TypeError exception ("this.Components is undefined") is thrown in specialpowersAPI.js (at http://hg.mozilla.org/mozilla-central/annotate/ab6426d96c6d/testing/specialpowers/content/specialpowersAPI.js#l625) when Webapps.js is firing the install success event (at http://hg.mozilla.org/mozilla-central/annotate/8e54082157d0/dom/apps/src/Webapps.js#l47).
Priority: -- → P1
Attached patch Patch (obsolete) — Splinter Review
I've written a basic test for this to at least cover the most important code paths.
Attachment #8499299 - Flags: review?(myk)
Attached patch Patch (obsolete) — Splinter Review
Attachment #8499299 - Attachment is obsolete: true
Attachment #8499299 - Flags: review?(myk)
Attachment #8499301 - Flags: review?(myk)
Attachment #8499301 - Flags: review?(myk) → review+
Attached patch PatchSplinter Review
Fixed commit message.
Assignee: nobody → mar.castelluccio
Attachment #8499301 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8502970 - Flags: review+
Keywords: checkin-needed
hi, could you provide a try run for this, thanks!
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/0738005d0ff5
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/0738005d0ff5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.