1006500 - Expose hit-target fluffing prefs as settings.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Jan Keromnes [:janx]]

Bug 965293 needs to access the `ui.touch.radius.{top,left,bottom,right}mm` pref values in order to visually draw the hit-target fluffing area of a touch on a device screen.

Thus these prefs should be linked to Firefox OS settings, but it's probably not useful to make these editable in the Settings app.

Comment 1

[Jan Keromnes [:janx]]

Attachment: Sort settings to observe. r=ochameau

Comment 2

[Jan Keromnes [:janx]]

Attachment: Expose hit-target fluffing prefs as settings. r=ochameau

Comment 3

[Jan Keromnes [:janx]]

Comment on attachment 8418422 [details] [diff] [review]
Sort settings to observe. r=ochameau

Sorry for the stupid patch, couldn't resist. No change apart from the better order.

Comment 4

[Jan Keromnes [:janx]]

Comment on attachment 8418423 [details] [diff] [review]
Expose hit-target fluffing prefs as settings. r=ochameau

Needed to draw the hit-target fluffing area in bug 965293.

Comment 5

[Alexandre Poirot [:ochameau]]

Comment on attachment 8418422 [details] [diff] [review]
Sort settings to observe. r=ochameau

Review of attachment 8418422 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good but I'm not reviewer of this file.

::: b2g/chrome/content/settings.js
@@ +603,5 @@
>  // =================== Various simple mapping  ======================
>  let settingsToObserve = {
> +  'app.update.interval': 86400,
> +  'app.update.channel': { resetToPref: true },
> +  'app.update.url': { resetToPref: true },

channel < interval < url ;)

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8418423 [details] [diff] [review]
Expose hit-target fluffing prefs as settings. r=ochameau

Review of attachment 8418423 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/chrome/content/settings.js
@@ +652,5 @@
>    },
> +  'ui.touch.radius.leftmm': { resetToPref: true },
> +  'ui.touch.radius.topmm': { resetToPref: true },
> +  'ui.touch.radius.rightmm': { resetToPref: true },
> +  'ui.touch.radius.bottommm': { resetToPref: true },

nit: Let's expand the {}. (makes smaller diff and easier |blame| when you need to add/edit something.

Comment 7

[Jan Keromnes [:janx]]

Attachment: Sort settings to observe. r=21 f=ochameau

Comment 8

[Jan Keromnes [:janx]]

Attachment: Expose hit-target fluffing prefs as settings. r=21 f=ochameau

Comment 9

[Jan Keromnes [:janx]]

Rebased and nits addressed, thanks for the review!

Cabin crew, doors to automatic and cross check, we're taking off.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/22e8b2a218da
https://hg.mozilla.org/integration/b2g-inbound/rev/0961957fee8b

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/22e8b2a218da
https://hg.mozilla.org/mozilla-central/rev/0961957fee8b