965293 - Visually show touch interaction with the device.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Such a tool will be useful for moz developers in order to debug some issues like the one described in https://bugzilla.mozilla.org/show_bug.cgi?id=947337#c48.

It will also be useful to help enhancing the fluffling algorithm by drawing the fluffed area following the finger. It then can be enhance by reporting the fluffing candidates in a followup.

It may also be useful for app developers if they want to optimize their UI for fluffing, as it is not always obvious to understand which elements will be selected by the touch code.

I can imagine a canvas based layer where touches are drawn for example.

Comment 1

[Paul Rouget [:paul]]

What would be the best way to intercept all the touch events from shell.html?

Comment 2

[Jan Keromnes [:janx]]

needinfo vingtetun for the best way to intercept touch events

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Paul Rouget [:paul] from comment #1)
> What would be the best way to intercept all the touch events from shell.html?

Which the underlying patch I have provided in the dependency you will just need to addEventListener('touchstart/move/end') when the touch event debug pref is |true|.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #3)
> (In reply to Paul Rouget [:paul] from comment #1)
> > What would be the best way to intercept all the touch events from shell.html?
> 
> Which the underlying patch I have provided in the dependency you will just
> need to addEventListener('touchstart/move/end') when the touch event debug
> pref is |true|.

s/Which/With

Comment 5

[Jan Keromnes [:janx]]

Attachment: gaia pull request

WIP, misses tests.

Comment 6

[Jan Keromnes [:janx]]

Comment on attachment 8394041 [details] [review]
gaia pull request

Added a fadeout animation on touches. Vivien, how do you think I should test this?

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Jan Keromnes [:janx] from comment #6)
> Comment on attachment 8394041 [details] [review]
> gaia pull request
> 
> Added a fadeout animation on touches. Vivien, how do you think I should test
> this?

Spoked about it IRL, let's remove the needinfo?.

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8394041 [details] [review]
gaia pull request

Looks good. I'm curious to see if we support touchcancel and I would like to make sure we don't instantiate any devtools until the pref is flipped.

Comment 9

[Jan Keromnes [:janx]]

Comment on attachment 8394041 [details] [review]
gaia pull request

Updated the pull request with a dependence on 1005880 that fixes the homescreen issue.

I addressed most of the nits (except I didn't create a new devtools/ folder), and left the change as two separate commits: one with the canvas version, and one changing it to dom elements.

When things work better with the dom version, I'll squash the two commits, but for now several issues remain:

- (canvas version) too slow, shows up in profiles a lot
- (dom version) weird clipping bug when several touches are displayed
- (both) need some unit tests

Comment 10

[Jan Keromnes [:janx]]

Comment on attachment 8394041 [details] [review]
gaia pull request

Actually that's not really a feedback request. I need to file a bug about the graphics issue.

Comment 11

[Jan Keromnes [:janx]]

Filed bug 1006074 about the cropped divs issue, and updated the pull request with a workaround (using opacity:0.9 on each square rather than on the container div fixes the problem).

Comment 12

[Jan Keromnes [:janx]]

TODO:
- use hit-target fluffing dimensions instead of 20px*20px: http://dxr.mozilla.org/mozilla-central/source/b2g/app/b2g.js#729-740
- a few unit tests

Comment 13

[BMO Automation]

Firefox OS is not being worked on