Closed Bug 1006526 Opened 10 years ago Closed 10 years ago

Refactor zoom.js

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S1 (9may)
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: crdlc, Assigned: crdlc)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

Patch v1
190 bytes, text/html
kgrandon
: review+
Details 
      No description provided.
Assignee: nobody → crdlc
Blocks: 985459
Status: NEW → ASSIGNED
Attached file Patch v1 — 
This patch refactors the zoom.js lib and splits it into two files: zoom.js and layout.js. Also I fixed some minor issues in zoom.js because handlers were not removed properly and they are called several times. Thanks for the review Kevin.
Attachment #8418079 - Flags: review?(kgrandon)
Comment on attachment 8418079 [details]
Patch v1

There were some merge conflicts due to another patch, so I resolved them and landed: https://github.com/mozilla-b2g/gaia/commit/9154475012988010de3d06fa2ba99541b280b852
Attachment #8418079 - Flags: review?(kgrandon) → review+
Depends on: 1006628
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.0 S1 (9may)
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
status-b2g-v2.0: --- → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: