1006536 - After a (caldav) password change multiple password dialogs are still shown after bug 991723

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Unfortunately the patch in bug 991723 didn't take care of all cases. Our auth code is a little outdated with the new msgAsyncPrompter, we can do a lot of simplifications.

I will be uploading two patches, one for 2.6.5 - 3.3 that is less risky, and one for 3.4+ that does some more cleanup. I have tested this with two caldav servers and it seems to work fine.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Patch for 2.6.5 - 3.3

Starting with the release patch for now so we can get 2.6.5 out of the door. Cross your fingers that this works as expected!

Comment 2

[Mohit Kanwal [:redDragon]]

Comment on attachment 8418045 [details] [diff] [review]
Patch for 2.6.5 - 3.3

Review of attachment 8418045 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Tested with Sogo syncing 3 calendars via CALDAV, and changing all of their passwords on the servers. Lightning displayed 3 password prompts.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8418045 [details] [diff] [review]
Patch for 2.6.5 - 3.3

Mark, I would like to manually include this with Lightning 2.6.5, which has been built with Thunderbird 24.5.0. Therefore, I'd like to push it to comm-release's default and GECKO2450_2014042411_RELBRANCH, then retag THUNDERBIRD_24_5_0_RELEASE and THUNDERBIRD_24_5_0_BUILD1. Do you approve?

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8418045 [details] [diff] [review]
Patch for 2.6.5 - 3.3

Sure, seems reasonable

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I'm pushing this patch for all branches, even c-c. In case I don't get to the complete patch it wouldn't be so great to lose this functionality again.

https://hg.mozilla.org/releases/comm-esr24/rev/7df033e6e4bb
https://hg.mozilla.org/releases/comm-esr24/rev/372518bc6405

https://hg.mozilla.org/releases/comm-beta/rev/dbc0a24d517c
https://hg.mozilla.org/releases/comm-aurora/rev/6022cfee2d54
https://hg.mozilla.org/comm-central/rev/dd042f1e688e

I will work on the new patch for c-c in a different bug.

Comment 6

[Martin Schröder [:mschroeder]]

Philipp, how is this targeting 2.6.5 as the version has already been released? ;)

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I cheated and patched the XPI manually before I uploaded it to AMO. I believe I also patched releases.m.o, but go ahead and double check.