1006775 - Web Literacy competency view does not render in Internet Explorer

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Aki Rose Braun [:akirose]]

Attachment: z5t0y.png

Steps to reproduce
1. load webmaker.org/explore (v1.0.83) on staging in IE 10
2. Click on any competency in left nav

Console result:
`InvalidStateError<div class="explore-main ng-scope" ng-view="">`

Visual result:
Navigation item becomes highlighted, view template loads, but never fully renders
(browser screenshot attached)

Comment 2

[Aki Rose Braun [:akirose]]

full console output:

HTML1300: Navigation occurred.
File: weblit-Remix
InvalidStateError <div class="explore-main ng-scope" ng-view="">
   {
      [functions]: ,
      __proto__: { },
      ABORT_ERR: 20,
      code: 11,
      constructor: { },
      DATA_CLONE_ERR: 25,
      DOMSTRING_SIZE_ERR: 2,
      HIERARCHY_REQUEST_ERR: 3,
      INDEX_SIZE_ERR: 1,
      INUSE_ATTRIBUTE_ERR: 10,
      INVALID_ACCESS_ERR: 15,
      INVALID_CHARACTER_ERR: 5,
      INVALID_MODIFICATION_ERR: 13,
      INVALID_NODE_TYPE_ERR: 24,
      INVALID_STATE_ERR: 11,
      message: "InvalidStateError",
      name: "InvalidStateError",
      NAMESPACE_ERR: 14,
      NETWORK_ERR: 19,
      NO_DATA_ALLOWED_ERR: 6,
      NO_MODIFICATION_ALLOWED_ERR: 7,
      NOT_FOUND_ERR: 8,
      NOT_SUPPORTED_ERR: 9,
      PARSE_ERR: 81,
      QUOTA_EXCEEDED_ERR: 22,
      SECURITY_ERR: 18,
      SERIALIZE_ERR: 82,
      SYNTAX_ERR: 12,
      TIMEOUT_ERR: 23,
      TYPE_MISMATCH_ERR: 17,
      URL_MISMATCH_ERR: 21,
      VALIDATION_ERR: 16,
      WRONG_DOCUMENT_ERR: 4
   }
   "<div class="explore-main ng-scope" ng-view="">"

Comment 3

[Aki Rose Braun [:akirose]]

Attachment: http://snaps.akibraun.com/6nvcv.png

Updated screen shot

Comment 4

[Atul Varma [:atul]]

I think I found the problem! Applying this simple fix to the MakeAPI client library makes things work on my end:

https://github.com/mozilla/makeapi-client/pull/38

On a somewhat more worrisome note, though: the original exception thrown by IE is being masked in the webmaker.org code, which is why it was so hard to discover--I ended up having to just drop console.log()'s everywhere because IE11's debugger wasn't even treating it as an exception. On the smoke test I wrote for makeapi-client, though (see https://github.com/mozilla/makeapi-client/issues/37), IE11's error feedback is perfect: the debugger kicks in on the exact line that's causing the crash.

So it seems like that useful information might be caught by the Angular competencyController in public/js/angular/controllers.js, and munged in a way that makes the error very hard to debug in IE11. :(

Comment 5

[Jon Buckley [:jbuck]]

Attachment: https://github.com/mozilla/makeapi-client/pull/38

Comment 6

[Cassie McDaniel [:cassiemc]]

Is this done, can we close?

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/4a7775c9ac31b894b464b426252b93c4d9f91191
Fix bug 1006775 - Update to makeapi-client v0.5.25

Comment 9

[Aki Rose Braun [:akirose]]

Okay so emoji breaks bugzilla. Atul, you are my hero.

Comment 10

[Atul Varma [:atul]]

No problem! Let me know if there are any other IE problems that you need resolved in a pinch. For some reason I find fixing IE issues therapeutic.