1006906 - Use hidpi icons for the variables view in widgets.inc.css

Status: RESOLVED FIXED

(DevTools :: Object Inspector, defect)

Description

[Victor Porof [:vporof][:vp]]

Seems like a regression/leftover from bug 943883?

Comment 1

[Victor Porof [:vporof][:vp]]

Hg blame tells me it's bug 952277.

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8419145 [details] [diff] [review]
v1

Review of attachment 8419145 [details] [diff] [review]:
-----------------------------------------------------------------

What do you think about uncommenting it and using the [e-mail] icon here?  It's in the project already, but needs to be added to the jar.mn files.

Comment 4

[Victor Porof [:vporof][:vp]]

Sure, why not.

Comment 5

[Victor Porof [:vporof][:vp]]

We should probably do the same for the other icons as well!

Comment 6

[Brian Grinstead [:bgrins]]

Looks like all of them are in the project already in themes/shared/devtools/images.  The ones using background image are easy - just set background-size to 16px 16px or whatever the image size is, then replace the URL.  Looks like the ones with list-style-image may just require replacing the URL, but I always check with layout.css.devPixelsPerPx = 2 just to make sure

Comment 7

[Victor Porof [:vporof][:vp]]

Attachment: v2

Comment 8

[Victor Porof [:vporof][:vp]]

Attachment: v3

Rebased. Sorry for the extra r?.

Comment 9

[Brian Grinstead [:bgrins]]

Comment on attachment 8419568 [details] [diff] [review]
v3

Review of attachment 8419568 [details] [diff] [review]:
-----------------------------------------------------------------

Nice refactors!

Comment 10

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/d0e180f6eebc

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d0e180f6eebc