Closed Bug 1007066 Opened 6 years ago Closed 5 years ago

The permission prompt appears below the attention screen

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(feature-b2g:2.0)

RESOLVED FIXED
2.0 S3 (6june)
feature-b2g 2.0

People

(Reporter: ferjm, Assigned: gasolin)

References

Details

(Whiteboard: ft:loop [p=1])

Attachments

(1 file)

If bug 988212 is finally done, privileged apps that require user explicit permissions for actions done within the attention screen won't be able to prompt the user about it because the permission prompt will be hidden behind the attention screen. This will be the case for any WebRTC app like the Loop client when the gUM permission prompt is triggered if the WebRTC call happens within the attention screen (which is a product requirement for Loop)
Do you think that it would be possible to place the permission screen on top of the attention screen?
Flags: needinfo?(alive)
Depends on: 1015894
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #2)
> Sure if we have bug
> attention-window(https://bugzilla.mozilla.org/show_bug.cgi?id=attention-
> window) and bug
> permission-dialog(https://bugzilla.mozilla.org/show_bug.cgi?id=permission-
> dialog)

For the permission dialog I'm going to land bug 1015894 that should fire the permission prompt request event on the related mozbrowseriframe. That's not the perfect solution as it does not offer an API on top of mozbrowser but it is safe enough for 2.0.

So the parts that still needs to be done is the PermissionDialog attached to the container of the related mozbrowser iframe. Is Gasolin the person working on that ?
Flags: needinfo?(alive)
Whiteboard: ft:loop
(In reply to Vivien Nicolas (:vingtetun) (:21) (NOT reading bugmails, needinfo? please) from comment #3)
> (In reply to Alive Kuo [:alive][NEEDINFO!] from comment #2)
> > Sure if we have bug
> > attention-window(https://bugzilla.mozilla.org/show_bug.cgi?id=attention-
> > window) and bug
> > permission-dialog(https://bugzilla.mozilla.org/show_bug.cgi?id=permission-
> > dialog)
> 
> For the permission dialog I'm going to land bug 1015894 that should fire the
> permission prompt request event on the related mozbrowseriframe. That's not
> the perfect solution as it does not offer an API on top of mozbrowser but it
> is safe enough for 2.0.
> 
> So the parts that still needs to be done is the PermissionDialog attached to
> the container of the related mozbrowser iframe. Is Gasolin the person
> working on that ?

Yes.

Fred, please let me know if you are able to work on bug permission-dialog for 2.0 timeframe.
Flags: needinfo?(alive) → needinfo?(gasolin)
Yes I think I could rearrange my working item if this got the priority.
Flags: needinfo?(gasolin)
feature-b2g: --- → 2.0
Depends on: permission-dialog
Depends on: attention-window
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
seems we can Promote level 5 elements to attention screen level when there is an active attention screen not minimized in the status bar. therefore we don't need implement full attention window and permission dialog in app window when 2.0 is branching.
Attachment #8433801 - Flags: feedback?(alive)
Comment on attachment 8433801 [details] [review]
pull request redirect to github

I guess we have no other choice for 2.0.
Attachment #8433801 - Flags: feedback?(alive) → feedback+
Attachment #8433801 - Flags: review?(alive)
Attachment #8433801 - Flags: review?(alive) → review+
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/a24a43bd0124f5ba49833aa30a44424dd18cef38

thanks!
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: ft:loop → ft:loop [p=1]
Target Milestone: --- → 2.0 S3 (6june)
Vivien, Fred
do we need to fix Bug 927862 and bug 853711? 
According to Vivien's mail sent last Tuesday they seem that they are not necessary and in that case I will remove the dependencies with this bug. Can you confirm it, please?
Thanks a lot!
Flags: needinfo?(gasolin)
Flags: needinfo?(21)
With current implementation, we don't need to fix Bug 927862 and bug 853711 first to fix this bug.

They are still worth to do but not block this issue though.
No longer depends on: permission-dialog, attention-window
Flags: needinfo?(gasolin)
Depends on: 1040406
You need to log in before you can comment on or make changes to this bug.