1040406 - [B2G][Flame][Dialer] Receiving a call while on the full screen permission prompt results in the incoming call being hidden

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Rachel Pribble [:rpribble]]

Attachment: Logcat.txt

Description:
If the user is watching a video (video at youtube.com used in test) and taps the icon to show the video full screen, then receives an incoming call while they are on the full screen permissions pop-up, the incoming call will not display in front of the permissions prompt.  If the user has the volume/ringer turned down on their device, they will not be aware of the incoming call.

Repro Steps:
1) Update a Flame to BuildID: 20140717000201
2) Turn volume and ringer down to silent
3) Begin watching a video (youtube.com)
4) Tap the icon to move the video to full screen, but do not click 'allow' yet
5) Place a call from another device to the DUT

Actual:
The incoming call does not display in front of the full screen permissions prompt and the user may not be aware of the call if their volume and ringer is turned down.

Expected:
The incoming call displays in front of any other operations so that the user can see the call.

Environmental Variables:
Device: Flame 2.0 MOZ ril (273MB)
Build ID: 20140717000201
Gaia: aa4f795b81c6147d67c4f06009e166debcf8856e
Gecko: 0ec0b9ac39f0
Version: 32.0a2 (2.0) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.

Notes:

Repro frequency: 100%
See attached: Video (http://youtu.be/6GXga2EcqUs), logcat

------------------------------------------

This issue also occurs on the Flame v2.1 MOZ ril(273MB), Buri v2.1 MOZ ril, Flame v2.0 (512MB), and Buri v2.0 MOZ ril.

"Environmental Variables:
Device: Flame Master (273MB)
Build ID: 20140717040202
Gaia: Unknown
Gecko: a74600665875
Version: 33.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0"

"Environmental Variables:
Device: Flame 2.0 MOZ ril (512MB)
Build ID: 20140717000201
Gaia: aa4f795b81c6147d67c4f06009e166debcf8856e
Gecko: 0ec0b9ac39f0
Version: 32.0a2 (2.0) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32."

"Environmental Variables:
Device: Buri Master
Build ID: 20140717040202
Gaia: Unknown
Gecko: a74600665875
Version: 33.0a1 (Master)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0"

"Environmental Variables:
Device: Buri 2.0 MOZ ril
Build ID: 20140717000201
Gaia: aa4f795b81c6147d67c4f06009e166debcf8856e
Gecko: 0ec0b9ac39f0
Version: 32.0a2 (2.0)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0"

The incoming call does not display in front of the full screen permissions prompt and the user may not be aware of the call if their volume and ringer is turned down.

------------------------------------------

This issue does not occur on the Flame v1.4(273MB), Buri v1.4 MOZ ril, and Open_C v1.4.

Environmental Variables:
Device: Flame 1.4 MOZ ril (273MB)
Build ID: 20140717063007
Gaia: e0a732cf172d125eadfad59f0faf8f73b62012b8
Gecko: 074223c547af
Version: 30.0 (1.4) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Environmental Variables:
Device: Buri 1.4 MOZ ril
Build ID: 20140717000201
Gaia: e0a732cf172d125eadfad59f0faf8f73b62012b8
Gecko: a429f0b6206d
Version: 30.0 (1.4)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Environmental Variables:
Device: Open_C 1.4 MOZ ril
Build ID: 20140717063007
Gaia: e0a732cf172d125eadfad59f0faf8f73b62012b8
Gecko: 074223c547af
Version: 30.0 (1.4)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

The incoming call displays in front of any other operations so that the user can see the call.

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

This is not ideal behavior but the user can tap "Don't allow" or "Allow" and answer the call without issue so not nominating this as a blocker even though it is a regression.

Comment 2

[Jason Smith [:jsmith]]

Beatriz - Can you find out if this issue could be a certification blocker or not?

Comment 3

[Beatriz Rodríguez [:brg]]

The issue described will be a certification blocker.
However, I had just tried to test with Flame v2.0(512MB and 1GB) today build( Gecko-745b486.Gaia-0a86498) and youtube is not asking for permission to change to fullscreen mode, so I used camera instead when asking to know my location.... The incoming call screen is always shown.
I do not know if behaviour may have change 10 days... but I guess it is worthy that someone from QA can recheck it.

Comment 4

[Jason Smith [:jsmith]]

QA Wanted for a retest on 2.0 on 319 MB Flame.

Comment 5

[Cody Roesch [:croesch]]

Tested the www.Youtube.com because the App does not throw a permission window when going fullscreen.

This bug DOES repro on Flame 2.0 319mb. When the permission screen is up, any incoming calls will not show above the permission window.

Environmental Variables:
Device: Flame 2.0
Build ID: 20140728065913
Gaia: b56f023ff247312a344e8f233898e803459788b9
Gecko: e11d0b232ced
Version: 32.0 (2.0)
Firmware Version: v122

Comment 6

[Joshua Mitchell (Inactive)]

[Blocking Requested - why for this release]: per comment 3, this behaviour will be a certification blocker

Comment 7

[Chris Kreinbring [:CKreinbring]]

Regression window
Last working
Build ID: 20140605183358
Gaia: 908f94fda04462001ece86e6b6c15ad8b05f7526
Gecko: 90b7c043acc3
Version: 32.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

First broken
Build ID: 20140605190759
Gaia: 857129928b6e56a809cee9d5445effb8fa9f1c2c
Gecko: 4a552fb1ca38
Version: 32.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Working Gaia / Broken Gecko = No repro
Gaia: 908f94fda04462001ece86e6b6c15ad8b05f7526
Gecko: 4a552fb1ca38
Broken Gaia / Working Gecko = Repro
Gaia: 857129928b6e56a809cee9d5445effb8fa9f1c2c
Gecko: 90b7c043acc3
Gaia push log: https://github.com/mozilla-b2g/gaia/compare/908f94fda04462001ece86e6b6c15ad8b05f7526...857129928b6e56a809cee9d5445effb8fa9f1c2c

B2G-inbound
Last working
Build ID: 20140604232916
Gaia: 908f94fda04462001ece86e6b6c15ad8b05f7526
Gecko: fff0aef110dd
Version: 32.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

First broken
Build ID: 20140604233716
Gaia: a24a43bd0124f5ba49833aa30a44424dd18cef38
Gecko: 37a23a635be0
Version: 32.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Working Gaia / Broken Gecko = No repro
Gaia: 908f94fda04462001ece86e6b6c15ad8b05f7526
Gecko: 37a23a635be0
Broken Gaia / Working Gecko = Repro
Gaia: a24a43bd0124f5ba49833aa30a44424dd18cef38
Gecko: fff0aef110dd
Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/908f94fda04462001ece86e6b6c15ad8b05f7526...a24a43bd0124f5ba49833aa30a44424dd18cef38

Comment 8

[Joshua Mitchell (Inactive)]

Broken by bug 1007066 ?

Comment 9

[[e-mail]]

The call screen is also a kind of attention screen. While general attention screen will be overlapped by permission screen after bug 1007066, call screen is overlapped as well.

The short fix might be put call_screen to higher z-index level, to distinguish from other attention screen.

`#screen > [data-z-index-level="attention-screen"][name="call_screen"]`


@alive is this a proper way to fix this issue?

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Fred Lin [:gasolin] from comment #9)
> The call screen is also a kind of attention screen. While general attention
> screen will be overlapped by permission screen after bug 1007066, call
> screen is overlapped as well.
> 
> The short fix might be put call_screen to higher z-index level, to
> distinguish from other attention screen.
> 
> `#screen > [data-z-index-level="attention-screen"][name="call_screen"]`
> 
> 
> @alive is this a proper way to fix this issue?

Don't think messy zindex helps.
Please dismiss current permission dialog once attentionscreenshow event is got.

Comment 11

[[e-mail]]

Attachment: pull request redirect to github

Thanks for feedback. 

The patch 

1. dismiss current permission dialog once `attentionscreenshow` event is received.
2. test added

Have to keep zindex hack in bug 1007066 because it needs to show permission dialog within the attention screen...

Comment 12

[[e-mail]]

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/2daa6f0100bce7b7fdddf094a38edb8080ba03d8

thanks!

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/717227d25e5d3e06da02a0989563d9d0c35af587

Comment 14

[Paladin]

This issue has been verified successfully on Flame 2.0,2.1

See attachment: Verify_video.3gp
Reproducing rate: 0/5
FLame 2.0 build:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141202000201
Version         32.0
Flame 2.1 build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141202001201
Version         34.0

Comment 15

[Paladin]

Attachment: Verify_video.3gp