1007225 - Hide titlebar-placeholder when not draw in titlebar

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

Bug 768516 introduced the possibility to draw into the titlebar under OS X. When this is enabled one time and later disabled again, the tabbar has still the spaces at the start and end.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: hideTitlebar-placeholder.patch

This patch adds the same rule we have already on Windows.

Comment 2

[Josiah Bruner [:jsbruner]]

Comment on attachment 8418846 [details] [diff] [review]
hideTitlebar-placeholder.patch

Review of attachment 8418846 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, looks good.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/75cacce22b79

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 8418846 [details] [diff] [review]
hideTitlebar-placeholder.patch

[Approval Request Comment]
Regression caused by (bug #): 768516
User impact if declined: when user switches back to "not draw in titlebar" will have on both sides of the tabbar unused space.
Testing completed (on c-c, etc.): in c-c and the same code is in Windows theme since long time.
Risk to taking this patch (and alternatives if risky): small, only CSS change.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8418846 [details] [diff] [review]
hideTitlebar-placeholder.patch

Looks like we missed landing this. Flagging for esr.

Comment 6

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-esr31/rev/583011db5903