Closed Bug 1007303 Opened 6 years ago Closed 6 years ago

SeaMonkey should fix common scheme typos

Categories

(SeaMonkey :: Tabbed Browser, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.29

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(2 files)

Basically a port of the front-end parts of bug 935377.
Attached patch Proposed patchSplinter Review
Because we funnel almost everything through loadURI or addTab we don't have so many places where we need to specify the flags. I thought it was better to update editor's version of the open location dialog to use the new parameter format (postData + boolean fixup flag instead of integer load flags).
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #8418938 - Flags: review?(iann_bugzilla)
Attachment #8418938 - Flags: feedback?(philip.chee)
Removed in bug 945627.
Attachment #8419047 - Flags: feedback?(philip.chee)
Comment on attachment 8418938 [details] [diff] [review]
Proposed patch

Does anything need doing with regards to nsBrowserContentHandler.js and function resolveURIInternal?

r=me with that addressed.
Attachment #8418938 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 8419047 [details] [diff] [review]
With isUTF8 removal

Works as expected. [is there a pref to turn thi on/off?]
Attachment #8419047 - Flags: feedback?(philip.chee) → feedback+
Attachment #8418938 - Flags: feedback?(philip.chee) → feedback+
(In reply to Philip Chee from comment #4)
> is there a pref to turn this on/off?

Yes, there's a hidden pref browser.fixup.typo.scheme which defaults to true.
Pushed comm-central changeset 69ff925f41a2.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.29
Aargh I checked it in with r=Ratty for some reason :-(
You need to log in before you can comment on or make changes to this bug.