1007396 - [B2G][Camera][Open-C] Camera preview displays slightly distorted color. Correct color briefly displayed when capturing image.

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Vendcom, defect)

Description

[Ross Kuhlman ([e-mail])]

When using the camera, the image preview does not display the correct color. The image appears to have overly high contrast. When the user takes a picture, the screen will briefly flash the correct color. When ovserving the image taken, the colors are noticeably different from how they appear in the image preview.

Repro Steps:
1) Updated Open_C to Build ID: 20140507000202
2) Launch camera
3) observe colors in image preview.
4) Take a picture of a colorful object.

Actual:
The color of the object in the picture is a different hue than the color in the image preview

Expected:
Image preview accurately represents the color in the final image

Environmental Variables
Device: Open C v1.4
Build ID: 20140507000202
Gecko: 8040ccd0d4b1
Gaia: bac831d2ebc567f0939e41fbd8a4c15ef183b954
Platform Version: 30.0
Firmware Version: P821A10V1.0.0B06_LOG_DL

Notes:
Repro frequency: 100%

Comment 1

[Ross Kuhlman ([e-mail])]

Adding link to video of issue. Observe color post-it note onscreen

https://www.youtube.com/watch?v=fr0sQh6NL2Q

Comment 2

[Jason Smith [:jsmith]]

QA Wanted to see if this happens on a 1.3 Open C base image.

Comment 3

[pete siphantong [:Petes]]

This issue does not reproduce on the 1.3 Open C base image US_EBAY_P821A10V1.0.0B06_LOG_DL

Comment 4

[pete siphantong [:Petes]]

This issue does not occur because the preview feature was not implemented yet  

1.3 Environmental Variables:
Device: Open_C 1.3 MOZ
BuildID: 20140505052400
Gaia: Unknown Git commit; build date shown here.
Gecko:
Version: 28.0
Firmware Version: FFOS_US_EBAY_P821A10V1.0.0B06_LOG_DL

Comment 5

[Jason Smith [:jsmith]]

Can we see what happens on a Flame device?

Comment 6

[Jason Smith [:jsmith]]

FWIW - Marcia & I can reproduce this on 1.4.

Comment 7

[Mike Habicher [:mikeh] (high bugzilla latency)]

(In reply to Jason Smith [:jsmith] from comment #6)
>
> FWIW - Marcia & I can reproduce this on 1.4.

On a Flame device?

To my knowledge, we're not doing anything in the app/Gecko that would cause this colour shift.

Justin, could the "shutter effect" be causing weirdness?

Comment 8

[Jason Smith [:jsmith]]

(In reply to Mike Habicher [:mikeh] from comment #7)
> (In reply to Jason Smith [:jsmith] from comment #6)
> >
> > FWIW - Marcia & I can reproduce this on 1.4.
> 
> On a Flame device?

On Open C. We did a comparison test with the Nexus device vs. the Open C with a pack of yellow sticky notes and saw that the color was far more white on the Open C device. The Nexus device had the right color.

Comment 9

[Mike Habicher [:mikeh] (high bugzilla latency)]

(In reply to Jason Smith [:jsmith] from comment #8)
> 
> The Nexus device had the right color.

POVB, then?

Comment 10

[Jason Smith [:jsmith]]

(In reply to Mike Habicher [:mikeh] from comment #9)
> (In reply to Jason Smith [:jsmith] from comment #8)
> > 
> > The Nexus device had the right color.
> 
> POVB, then?

Let's first see what happens on Flame before we conclude that.

Comment 11

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue does NOT occur on the latest 1.4 Flame.

1.4 Environmental Variables:
Device: Flame 1.4 MOZ
BuildID: 20140508000201
Gaia: 4ce973ef0732b0d52cb043210db598aa176b2ce9
Gecko: 16ab7f6b18f8
Version: 30.0
Firmware Version: v10E

The device showed the correct colors for the preview image.

Comment 12

[chencong]

If user touch the screen of camera's preview, the preview color is correct. The driver parameter of preview and capture is the same.

Comment 13

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

Hi Peter, probably this is bug is irrelevant to you. But is it possible you can shed some lights such that our partner can keep checking this one?

In Open C, when user taps the camera preview screen, the color of the preview screen will change. I capture a video of this bug:

https://www.youtube.com/watch?v=Jxcoti_G4hw&feature=youtu.be

So partner is wondering why touching the screen will cause the screen color swift, so if possible, could you help to provide some suggestions as to how to check this bug?

Thanks

Comment 14

[Peter Chang[:pchang]]

ni chiajung to check the rendering path for camera preview flow.

Chiajung, please help to check this is related to HWC or not.

Comment 15

[Chiajung Hung [:chiajung]]

My local build can not reproduce this problem on both 1.4 and mainline.
I will try QA build later.

Comment 16

[Chiajung Hung [:chiajung]]

QA PVT build can not reproduce this issue, too.

Comment 17

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

(In reply to Chiajung Hung [:chiajung] from comment #16)
> QA PVT build can not reproduce this issue, too.

Hi Chiajung -

I cannot reproduce this one on other devices as well. But partner just want to know whether the rendering path for camera preview flow is changed after touching the camera preview screen. Could you kindly shed some lights(just point out where in the source code to look at will be fine) to partners?

Thanks

Vance

Comment 18

[chencong]

Hi Vance,

Thanks for your help. 
We find it's depend on MDP display.If user not used hardware compose, it can display OK.
We try to merge some MDP code from QC. It seems be improved.
This issue can be closed.

Comment 19

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

Hi Chen Cong, lovely, thanks!

Hi Chiajung - thanks for spending time on testing this one with various devices! Partner get some patches from QCT and now we can close this issue