Initial (v0) Deploy of Slaveloan tool

NEW
Assigned to

Status

Release Engineering
Tools
3 years ago
3 years ago

People

(Reporter: Callek, Assigned: Callek)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1949] )

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
To get slaveloan tool able to be iterated on by many humans, we need an initial skeleton deployed to do so.

This bug will handle that skeleton
(Assignee)

Comment 1

3 years ago
Created attachment 8419184 [details] [diff] [review]
[relengapi] WIP 1

Feedback welcome
Comment on attachment 8419184 [details] [diff] [review]
[relengapi] WIP 1

"Human" and "human" should be plural in the model.

Also, 'import *' is frowned upon by tools like pyflakes (and, I think, pep8) since it introduces arbitrary symbols into the namespace without any syntactic indication of *which* symbols.  Please change the * in __init__.py to list the model classes explicitly.

The POST to /admin/ should be a REST-style POST, rather than a browser form submission.  The differences are minor, but involve sending a JSON request in the POST body, rather than form-encoded, and flagging it with @apimethod.  You'll need to do a little jQuery work on the browser side to make that happen.  You can look at the tokenauth blueprint for an example of that.

Finally, please delete the dangling 'slaveloan/src' symlink
Attachment #8419184 - Flags: feedback+

Updated

3 years ago
Blocks: 1013511

Updated

3 years ago
No longer blocks: 1013511
(Assignee)

Updated

3 years ago
Depends on: 1075080

Updated

3 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1949]
You need to log in before you can comment on or make changes to this bug.