1007548 - The "Back" button should give some visual feedback when tapped

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Consumer Pages, defect, P5)

Description

[Federico 'klez' Culloca]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140421221237

Steps to reproduce:

- Go to https://marketplace.allizom.org/ with Fennec Nightly or Firefox OS app (tested with 1.3 on peak)
- Tap on any app
- Tap the back button


Actual results:

No visual feedback that i correctly tapped the button



Expected results:

The back button should give visual feedback while it goes back. The problem is that, since there's no visual feedback and the operation can take almost a second, I'm not sure I tapped correctly so I tap again and sometimes it "auto"-taps what's there on the previous page (usually another back button, so I find myself two pages back instead of just one)

Comment 1

[Daniele "Mte90" Scasciafratte]

Confirm the problem. A little spinner with an overlay?

Comment 2

[Wil Clouser [:clouserw]]

I'd like to know why this would ever be slow.  It's a soft back button, but the data it is loading should be coming out of our local cache - why wouldn't that be nearly instantaneous?

Comment 3

[Ram Dayal Vaishnav [:ram]]

Is this still being discussed or ready to be fixed (if yes, what exactly to be done)?

Thanks,
Ram

Comment 4

[Ram Dayal Vaishnav [:ram]]

Bharat was working on this bug during the marketplace day event (https://etherpad.mozilla.org/remo-marketplace-day-info), but it looks like he forgot to add the PR here. I am putting his PR on his behalf and adding him in CC & also raising needinfo for him if he has any comments here.

https://github.com/mozilla/fireplace/pull/1232/

Comment 5

[Ram Dayal Vaishnav [:ram]]

Hi Kevin,
Could you please tell us if the approach used in PR https://github.com/mozilla/fireplace/pull/1232 is correct? If not, this would be useful if you give some direction on how to fix this.

Thanks,
Ram

Comment 6

[Ram Dayal Vaishnav [:ram]]

FYI, the PR given in previous comments is closed, feel free to pick this good-first-bugs. Good Luck !

Comment 7

[Kevin Ngo [:ngoke]]

Probably slow because the device is slow. I'd just swap the SVG background-position to the blue arrow when :active

Comment 8

[sandeep504kmr]

i would like to fix this bug

Comment 9

[Ram Dayal Vaishnav [:ram]]

Sure Sandeep. Assigning you to this bug.

For any help you can refer to the documentation at http://marketplace.readthedocs.org/, or ask in #marketplace irc channel.

Thanks!

Comment 10

[sandeep504kmr]

I tried to change the properties of active section in .arrow-btn section. but it didn't worked. 


  &:active {
	
        background: $action-positive-tapped url(../img/pretty/arrow-l.svg) \
                    no-repeat 15px 50% / 15px 15px;


Is my approach correct to change the back button effect.?

Comment 11

[Ram Dayal Vaishnav [:ram]]

Hi Kevin, can you please advice on above?

Comment 12

[Kevin Ngo [:ngoke]]

As mentioned above, you need to change the background-position so that the Blue Arrow portion of the SVG is visible.

Comment 13

[Mark Striemer [:mstriemer]]

We are no longer using the SVG back button. It is now the "hambacker" element. The changes should be made in hambacker.styl [1] either by using a scale or by changing the background colour.

[1] https://github.com/mozilla/fireplace/blob/ed334cd1bca0bfccaf8dee0d81e68b8396b33721/src/media/css/lib/hambacker.styl

Comment 14

[Mark Striemer [:mstriemer]]

I think it looks better with a scale than a colour change but feel free to play around with it. The transition should be faster on the down state that the up state. So change colour or shrink almost immediately but take a bit longer to come back to normal.

Comment 15

[Ram Dayal Vaishnav [:ram]]

Sandeep are you still working on this bug? Please check above comments for suggestions on how to fix this.

Comment 16

[rits]

Hello, i would like to work on this bug.

Comment 17

[Ram Dayal Vaishnav [:ram]]

Assigning this bug to rits as Sandeep is inactive on this.

Comment 18

[rits]

Hello, i have been working on the bug according to the steps provided above, but i couldn't figure out how to produce it on the localhost, as the bug is related to the mobile app. 
Please provide some further directions about it. 

Thanks

Comment 19

[Ram Dayal Vaishnav [:ram]]

Hi rits, you can reproduce this on responsive view on browser (ctrl+shft+M on firefox). You might not be able to see this issue on very first place because on the browser page navigation is faster.

Comment 20

[Chuck Harmston [:chuck]]

Hey Phil, could you advise Rits how you'd like this to behave?

Comment 21

[Andrew Williamson [:eviljeff]]

We don't think this is a worthwhile fix, but if you really want to work on it, we can re-open.

Comment 22

[rits]

Hello eviljeff
what should be the workaround according to you for fixing this bug.

Comment 23

[Andrew Williamson [:eviljeff]]

(In reply to rits from comment #22)
> Hello eviljeff
> what should be the workaround according to you for fixing this bug.

There is no workaround, its not as important now - the back button only appears in a few places with the most recent redesign, and on each of those the previous page should already be cached so the transition should be instant.

Comment 24

[rits]

@eviljeff
I think then working for it as a temporary solution would not be enough, its good as Resolved then.
Thanks