1007558 - Move l10n.js out of keyboard app start-up path

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #995025 +++

The aria label are programmatically get with _() function. This create a dependency and force l10n.js to load before keyboard.js et al. 

We want to move that out of the start-up path. The correct way to do things would be set the data-l10n-ids (say, 'foo') of the elements, and l10n.js will fill the labels from l10n properties with id like |foo.aria-label|.

I have a WIP patch but I haven't make sure it really works.

:eeejay, since you land the patch just yesterday, would you be able to work on this follow-up?

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This is my WIP

https://github.com/timdream/gaia/tree/keyboard-startup-l10n

Comment 2

[Eitan Isaacson [:eeejay]]

Sure, I'll take this on. Thanks.

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19076

Your approach of adding nodes with data-l10n-id does not work, since the document is already loaded, and l10n.js only traverses the doc on load. But this really shouldn't be an issue, since the these translated strings are needed only at render time, and l10n.get is not called until the last moment.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8419648 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19076

I know it was r+'d but could you also move the |getAriaLabel()| and related stuff out of keyboard.js into render.js? We really need to trim that file.

Also, your patch still synchronously trying to translate a label when constructing a keyboard node. I am thinking whether or not we have a way to do that out asynchronously, like calling l10n.translate() on a node

https://github.com/mozilla-b2g/gaia/blob/master/shared/js/l10n.js#L1163-L1165

I'll r+ if you do the first part in this bug. I can try to handle the second part later. Sorry for having you to work on such ill-maintained code.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

s/the first part in this bug/the first part of the comment above/

Comment 6

[Eitan Isaacson [:eeejay]]

Comment on attachment 8419648 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19076

Did what you asked!

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8419648 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19076

Looks good, but please rebase again, sorry about that.

Comment 8

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/53c8c1b543e34079b8c81b721ef5fe25cc8c8868