995025 - Word suggestions are not keyboard accessible

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Eitan Isaacson [:eeejay]]

1. They need to have an appropriate role.
2. Activating them seems to not work.
3. The dismiss x button is inaccessible too.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18960

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8417704 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18960

r+ as well.
Please help take a look at my comment within the pull request to address the unit test failure.

Please let me know if you need any help.
Thanks.

Comment 3

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/03cf6332a410f5b8cda3bc6edbdc56a8d14166af

Thanks!

Comment 4

[Francesco Lodolo [:flod]]

Not sure this bug is clear for me. Is there any difference between "Word suggestion" and "Word suggestions"?
Are they used for 1 suggestion, multiple suggestions? In that case I'm not sure it'll work for most locales with complex plural forms.

Comment 5

[Eitan Isaacson [:eeejay]]

(In reply to Francesco Lodolo [:flod] from comment #4)
> Not sure this bug is clear for me. Is there any difference between "Word
> suggestion" and "Word suggestions"?
> Are they used for 1 suggestion, multiple suggestions? In that case I'm not
> sure it'll work for most locales with complex plural forms.

wordSuggestion is the name of the feature that can be enabled or disabled.

wordSuggestions is the name of the section in the UI in which the different word suggestions appear. It is only explosed to screen reader users who hear "Word suggesions" when they pass their finger over that area.

Comment 6

[Francesco Lodolo [:flod]]

Thanks, that makes totally sense now. Would it be possible to add a localization comment for those two strings, explaining what you just wrote?

Comment 7

[Eitan Isaacson [:eeejay]]

(In reply to Francesco Lodolo [:flod] from comment #6)
> Thanks, that makes totally sense now. Would it be possible to add a
> localization comment for those two strings, explaining what you just wrote?

I put in some comments in the proposed patch in bug 1007558.