1007596 - Remove MozMillElement type detection because it is simply broken

Status: RESOLVED WONTFIX

(Testing Graveyard :: Mozmill, defect, P2)

Description

[Andrei Eftimie]

We've seen this in bug 830379 where the `pageNumber` input element is of type `number`.

MozMillTextBox fails to identify this element as an input type, thus missing its `sendKeys` method.

We should revise the checks MozMillTextBox does here:
https://github.com/mozilla/mozmill/blob/c305151b137dc7325a3b153e8b385389551389b7/mozmill/mozmill/extension/resource/driver/mozelement.js#L1181-L1186
To make sure we have all elements that can be typed into.

Here are all types available on input elements:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input

Out of these the following support typing:
- color
- date
- datetime
- datetime-local
- email 
- hidden (?)
- month
- number
- search 
- tel
- text
- time
- url
- week

Given the high number of input types we should support, maybe we should change the way we identify them. Maybe a blacklist would be better...

Or maybe question whether we need a MozMillTextBox type at all?
We could have sendKeys on the regular MozmillElement... with contentEditable=true any HTML element can and should be able to receive text input.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Instead of having such a long inclusion list, I would rename the class to MozMillInput and allow any type. Andrew, what is your point?

As we also talked about in our meeting today, the logic to determine the type of the elements is mostly over-enthusiastic and broken, especially for non-existent elements at this time. We should better get this removed totally and fallback to a single MozMillElement class. But that needs another discussion and bug.

Comment 2

[Andrew Halberstadt [:ahal]]

That seems reasonable to me. I think type checking was a bad idea in the first place. Better to do "feature detection" on the element and raise an exception if you try to use an incompatible method on it.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sounds great. Thanks Andrew.

I will take this so we can have it fixed soon for version 2.1. Old methods we will keep and mark them as deprecated.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozmill will reach its end of life soon. We are currently working on getting
all the tests for Firefox ported to Marionette. For status updates please see
bug 1080766.