1007701 - second updates run of 29.0.1 failed to submit to balrog

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[[e-mail] (:bhearsum)]

It got a 401 error, which is curious:
Caught HTTPError: ffxbld is not allowed to access /releases/:name by POST
Traceback (most recent call last):
  File "/builds/slave/rel-m-rel-updates-000000000000/tools/scripts/updates/balrog-release-pusher.py", line 88, in <module>
    release_config['enUSPlatforms'], hashType)
  File "/builds/slave/rel-m-rel-updates-000000000000/tools/lib/python/balrog/submitter/cli.py", line 95, in run
    data_version=data_version)
  File "/builds/slave/rel-m-rel-updates-000000000000/tools/lib/python/balrog/submitter/api.py", line 134, in update_release
    return self.request(method='POST', data=data, url_template_vars=dict(name=name))
  File "/builds/slave/rel-m-rel-updates-000000000000/tools/lib/python/balrog/submitter/api.py", line 103, in request
    return self.do_request(url, data, method, url_template_vars)
  File "/builds/slave/rel-m-rel-updates-000000000000/tools/lib/python/balrog/submitter/api.py", line 118, in do_request
    headers=headers)
  File "/builds/slave/rel-m-rel-updates-000000000000/tools/lib/python/vendor/requests-0.10.8/requests/sessions.py", line 203, in request
    r.send(prefetch=prefetch)
  File "/builds/slave/rel-m-rel-updates-000000000000/tools/lib/python/vendor/requests-0.10.8/requests/models.py", line 585, in send
    self.response.raise_for_status()
  File "/builds/slave/rel-m-rel-updates-000000000000/tools/lib/python/vendor/requests-0.10.8/requests/models.py", line 810, in raise_for_status
    raise http_error
requests.exceptions.HTTPError: 401 Client Error

Nightlies are still submitting without issue and the permissions look fine to me...

Comment 1

[[e-mail] (:bhearsum)]

Looks like this is because there's '"product": "firefox"' in buildprops_balrog.json, which makes this a regression from bug 1001428.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: capitalize.diff

So, product ends up getting set by this loop at the end of release.py right now:
https://github.com/mozilla/build-buildbotcustom/blob/master/process/release.py#L1936

That ends up getting used by the log uploader, which I guess is why it's lower case. This patch changes the product property to be capitalized, and forces the log uploader to lower case it. I think that makes more sense than the reverse, because ftp directories are always lower case.

Comment 3

[Chris Cooper [:coop] (he/him)]

Merged and deployed to production.

Comment 4

[[e-mail] (:bhearsum)]

Should be fixed for 30.0b3, which just started.

Comment 5

[[e-mail] (:bhearsum)]

i broke log uploading

Comment 6

[[e-mail] (:bhearsum)]

Attachment: lower case stuff for postrun

I think this will fix it...not sure if this needs a reconfig or not.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8419664 [details] [diff] [review]
lower case stuff for postrun

Should only need the second hunk here, since uploadLog() is calling getBuildInfo() to get product.

Comment 8

[[e-mail] (:bhearsum)]

Comment on attachment 8419664 [details] [diff] [review]
lower case stuff for postrun

Landed, merged to production, and updated the masters (changes to this file don't require a reconfig).

I'm requeuing all the jobs that failed, and they seem to be going through fine now.

Comment 9

[[e-mail] (:bhearsum)]

Should be fixed (again). Hopefully closing this bug so soon again doesn't jinx me...