Closed Bug 1007776 Opened 5 years ago Closed 5 years ago

Add a devtools API for muting the source AudioNodes

Categories

(Core :: Web Audio, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: jsantell, Assigned: ehsan)

References

Details

Attachments

(1 file)

AudioSourceNode's should be able to be muted.
The underlying code that I'm adding in bug 1007778 may help with muting the source nodes as well...
Assignee: nobody → ehsan
Component: Developer Tools: Web Audio Editor → Web Audio
Product: Firefox → Core
Summary: Muting AudioNode's with web audio editor → Add a devtools API for muting the source AudioNodes
FWIW I'm going to add passThrough attributes for the source nodes as well, but I'll wait until I get r+ on bug 1007778 before I write a patch for this.  You can use the same API on your side now, FWIW, if you take my experimental patch and add the necessary *.webidl chunks for AudioBufferSourceNode, MediaElement/StreamAudioSourceNode and OscillatorNode.
Depends on: 1007778
(semantically you can imagine that the source nodes in that case will be passing through their input which is silence to their output.)
Ehsan, that sounds perfect. Thank you so much!
Comment on attachment 8474909 [details] [diff] [review]
Add a devtools API for muting the source AudioNodes; r=roc,smaug

Again, smaug for WebIDL changes, roc for the rest.
Attachment #8474909 - Flags: review?(roc)
Attachment #8474909 - Flags: review?(bugs)
Attachment #8474909 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/eb7712477525
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.