1007776 - Add a devtools API for muting the source AudioNodes

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

AudioSourceNode's should be able to be muted.

Comment 1

[(no longer active)]

The underlying code that I'm adding in bug 1007778 may help with muting the source nodes as well...

Comment 2

[(no longer active)]

FWIW I'm going to add passThrough attributes for the source nodes as well, but I'll wait until I get r+ on bug 1007778 before I write a patch for this.  You can use the same API on your side now, FWIW, if you take my experimental patch and add the necessary *.webidl chunks for AudioBufferSourceNode, MediaElement/StreamAudioSourceNode and OscillatorNode.

Comment 3

[(no longer active)]

(semantically you can imagine that the source nodes in that case will be passing through their input which is silence to their output.)

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Ehsan, that sounds perfect. Thank you so much!

Comment 5

[(no longer active)]

Attachment: Add a devtools API for muting the source AudioNodes; r=roc,smaug

Comment 6

[(no longer active)]

Comment on attachment 8474909 [details] [diff] [review]
Add a devtools API for muting the source AudioNodes; r=roc,smaug

Again, smaug for WebIDL changes, roc for the rest.

Comment 7

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eb7712477525

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/eb7712477525