1055211 - Add bypass feature to AudioNodeActors

Status: RESOLVED FIXED

(DevTools Graveyard :: Web Audio Editor, defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

For exposing an API to bypass processing and source nodes for consumption on the client side tooling

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1055211-bypass-nodes.patch

First pass, works with the processing bypass (passThrough) -- unsure what the source node bypass will look like so may need to be updated

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1055211-audionodeactor-bypass.patch

Comment 3

[Victor Porof [:vporof][:vp]]

Comment on attachment 8491829 [details] [diff] [review]
1055211-audionodeactor-bypass.patch

Review of attachment 8491829 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/webaudioeditor/test/browser_audionode-actor-bypass.js
@@ +18,5 @@
> +  yield gainNode.bypass(true);
> +
> +  is((yield gainNode.isBypassed()), true, "Node is now bypassed.");
> +  
> +  

Nit: whitespace.

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1055211-audionodeactor-bypass.patch

nits fixed!

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Removing checkin-needed, waiting for try: https://tbpl.mozilla.org/?tree=Try&rev=54320611ab01

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

Wait to rebase once bug 1066450 lands

Comment 7

[Jordan Santell [:jsantell] [@jsantell]]

Rebased with bug 1066450, try: https://tbpl.mozilla.org/?tree=Try&rev=e71b960ae7d7

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/fc505cc75020

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fc505cc75020