Closed Bug 1055211 Opened 6 years ago Closed 6 years ago

Add bypass feature to AudioNodeActors

Categories

(DevTools Graveyard :: Web Audio Editor, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 35

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(1 file, 2 obsolete files)

For exposing an API to bypass processing and source nodes for consumption on the client side tooling
Depends on: 1007778
Assignee: nobody → jsantell
Depends on: 1007776
Attached patch 1055211-bypass-nodes.patch (obsolete) — Splinter Review
First pass, works with the processing bypass (passThrough) -- unsure what the source node bypass will look like so may need to be updated
Status: NEW → ASSIGNED
Attachment #8474734 - Attachment is obsolete: true
Attachment #8491829 - Flags: review?(vporof)
Comment on attachment 8491829 [details] [diff] [review]
1055211-audionodeactor-bypass.patch

Review of attachment 8491829 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/webaudioeditor/test/browser_audionode-actor-bypass.js
@@ +18,5 @@
> +  yield gainNode.bypass(true);
> +
> +  is((yield gainNode.isBypassed()), true, "Node is now bypassed.");
> +  
> +  

Nit: whitespace.
Attachment #8491829 - Flags: review?(vporof) → review+
nits fixed!
Attachment #8491829 - Attachment is obsolete: true
Attachment #8492428 - Flags: review+
Removing checkin-needed, waiting for try: https://tbpl.mozilla.org/?tree=Try&rev=54320611ab01
Keywords: checkin-needed
Wait to rebase once bug 1066450 lands
https://hg.mozilla.org/mozilla-central/rev/fc505cc75020
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.