1008033 - [Flame] [e.me Homescreen] Can't show more than 12 elements

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Build Information

Device: Flame
Gaia      4ce973ef0732b0d52cb043210db598aa176b2ce9
Gecko     https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/16ab7f6b18f8
BuildID   20140508000201
Version   30.0
ro.build.version.incremental=87
ro.build.date=Mon May  5 20:19:07 CST 2014


Steps to Reproduce
With an e.me homscreen containing 4 Smart Collections, go to marketplace, install 9 apps
Go to Everything.me Homescreen

Expected Results
All 9 apps are present on this page

Actual Results
The 9th app is not visible on any panel

Reproduction Frequency: 100%

Comment 1

[Jason Smith [:jsmith]]

This is expected behavior because one row on the e.me homescreen is taken up by the search bar, so there's only room to have 12 apps on the e.me homescreen page. So that means the 9th app you've installed would end up on a different homescreen page.

Comment 2

[Johan Lorenzo [:jlorenzo]]

Strange, I can have have 16 icons on the e.me homescreen on an Open C device. Furthermore, the 9th app doesn't appear on any other homescreen page (panel). If I uninstall an app from the e.me page, I the 9th install app appears at the 8th position.

Comment 3

[Jason Smith [:jsmith]]

Disregard - you should be able to get up to 16 apps on this page. Although as I showed in person, we couldn't reproduce this.

Comment 4

[Jason Smith [:jsmith]]

Saw this on Johan's device directly - it's reproducible there. I get the feeling we need clearer STR to nail this down.

I also noticed that the webapps.json showed that the app was installed, but the homescreen did not display the icon.

Comment 5

[Johan Lorenzo [:jlorenzo]]

More detailled STR:
Reset the device
Go through the FTU
Connect to Mozilla Guest
Go to Marketplace
Install popular apps in that order: ConnectA2, Whatsap FFOS Info, Loqui IM, LINE, Facebook, MessageMe, Pacmac Canvas, SoundCloud, YOUZEEK
Go to homescreen
Go to e.me homescreen

Actual
YOUZEEK is installed but not visible

Comment 6

[Jason Smith [:jsmith]]

Ok - let's check to see if we can reproduce this on 1.3 on a Flame base image.

Comment 7

[pete siphantong [:Petes]]

This issue is reproduce on the 1.3 Flame, instead YOUZEEK, the SoundCloud is installed but not visible

1.3 Environmental Variables:
Device: flame 1.3 MOZ
BuildID: 20140414142245
Gaia: 70d6403322ebbbc56b41ef4231e99597a92e3330
Gecko:
Version: 28.0
Firmware Version: v10E

Comment 8

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Obviously it seems a problem with devices with different resolution than 320x480 or dppx. I think so because I cannot reproduce it in my tarako or unagi. I don't have an Open C or any similar device. Could you Johan give my a hand and check my patch in your device? Thanks in advance

Comment 9

[Chris Lord [:cwiiis]]

Is it too late to get this fixed in 1.3? This bug affects devices that will be shipping and is easy to trigger and confusing - it can be worked around (awkwardly), but to a user it just looks like the app wasn't installed properly.

Even weirder, on the screens without the search bar, the number of visible apps isn't a multiple of 4.

Comment 10

[Chris Lord [:cwiiis]]

For more detail, the first screen with the search bar can't show more than 12, each subsequent screen can't show more than 14.

Comment 11

[Jason Smith [:jsmith]]

(In reply to Chris Lord [:cwiiis] from comment #9)
> Is it too late to get this fixed in 1.3? This bug affects devices that will
> be shipping and is easy to trigger and confusing - it can be worked around
> (awkwardly), but to a user it just looks like the app wasn't installed
> properly.
> 
> Even weirder, on the screens without the search bar, the number of visible
> apps isn't a multiple of 4.

I think it's too late for 1.3 - we're only blocking on critical certification issues at this point. I also don't think this is that easy to trigger - when I analyzed this with Johan, it required a specific set of installation steps to trigger the bug. Installing apps in a different order wouldn't necessarily trigger the bug. It's also user recoverable, although it's not a clean recovery path.

We can evaluate this for 1.4? though, as that's still being triaged for Mozilla-motivated blockers.

Comment 12

[Chris Lord [:cwiiis]]

(In reply to Jason Smith [:jsmith] from comment #11)
> I think it's too late for 1.3 - we're only blocking on critical
> certification issues at this point. I also don't think this is that easy to
> trigger - when I analyzed this with Johan, it required a specific set of
> installation steps to trigger the bug. Installing apps in a different order
> wouldn't necessarily trigger the bug. It's also user recoverable, although
> it's not a clean recovery path.

No specific steps are required, this bug is triggered every time you hit those icon limits. I'd be interested in knowing how you tested to produce different results, I hit this regardless of what apps I install or in what order.

The recovery step involves knowing what the bug is, that seems less than desirable. If an app icon fails to appear after I install it, why would I think to move an icon from one home-screen to another to install it? Or to uninstall an app on said home-screen?

> We can evaluate this for 1.4? though, as that's still being triaged for
> Mozilla-motivated blockers.

Being on 1.4 is certainly better than nothing though :)

Comment 13

[Jason Smith [:jsmith]]

(In reply to Chris Lord [:cwiiis] from comment #12)
> (In reply to Jason Smith [:jsmith] from comment #11)
> > I think it's too late for 1.3 - we're only blocking on critical
> > certification issues at this point. I also don't think this is that easy to
> > trigger - when I analyzed this with Johan, it required a specific set of
> > installation steps to trigger the bug. Installing apps in a different order
> > wouldn't necessarily trigger the bug. It's also user recoverable, although
> > it's not a clean recovery path.
> 
> No specific steps are required, this bug is triggered every time you hit
> those icon limits. I'd be interested in knowing how you tested to produce
> different results, I hit this regardless of what apps I install or in what
> order.

When I tested this with 9 random apps from marketplace, I could not reproduce this. I actually was only able to reproduce this via using the specific set of apps Johan called out. There might be other ways to trigger this, however.

Comment 14

[Chris Lord [:cwiiis]]

(In reply to Jason Smith [:jsmith] from comment #13)
> (In reply to Chris Lord [:cwiiis] from comment #12)
> > (In reply to Jason Smith [:jsmith] from comment #11)
> > > I think it's too late for 1.3 - we're only blocking on critical
> > > certification issues at this point. I also don't think this is that easy to
> > > trigger - when I analyzed this with Johan, it required a specific set of
> > > installation steps to trigger the bug. Installing apps in a different order
> > > wouldn't necessarily trigger the bug. It's also user recoverable, although
> > > it's not a clean recovery path.
> > 
> > No specific steps are required, this bug is triggered every time you hit
> > those icon limits. I'd be interested in knowing how you tested to produce
> > different results, I hit this regardless of what apps I install or in what
> > order.
> 
> When I tested this with 9 random apps from marketplace, I could not
> reproduce this. I actually was only able to reproduce this via using the
> specific set of apps Johan called out. There might be other ways to trigger
> this, however.

I literally cannot have more than 12 apps on the first home page or 14 apps on each subsequent page. It doesn't matter what the apps are or the order on which I install them - this is on a shipping Open C. I can reproduce this 100% of the time.

Another way you can trigger this is by putting 12 apps on your first screen, then trying to move an icon from another screen to the first screen. When you drop it, it will fly off screen and become inaccessible.

If it's at all an option to not ship this bug, I really think we should take that option.

Comment 15

[Cristian Rodriguez (:crdlc)]

It is always reproducible with bigger resolutions than 480x320 or bigger dppx. 

Scenario:

* 12 icons on the first page with ev.me. 
* Install or move one to first page (the 13th icon). Then it will be hidden although it is already installed there. 
* It will be displayed again when the user moves one icon from the first page to another one or the user uninstalls one app or bookmark from the first page

The bug will be fixed with bug bug 1008161 comment 7

Comment 16

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8420812 [details]
Patch v1

LGTM. The initial STR is no more reproducible with your patch. I couldn't reproduce Christian's scenario with my flame device.

Comment 18

[Cristian Rodriguez (:crdlc)]

This is was fixed once bug 1008161 was landed

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/70953f779faf6b1a94861c34ffdc3d5fd1c442e5

Comment 19

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/2e97bee6bb79d3577dba1bf2a1bbfcba64ee99ab

Comment 21

[mkruml]

Verified in 1.4 Flame/Open_C and 2.0 Flame

1.4 Environmental Variables:
Device: Open_C 1.4 MOZ
BuildID: 20140522000200
Gaia: 233dd43b3b976e66a619dbc1b4044ed1e3ca3e34
Gecko: c3c0c57daef8
Version: 30.0
Firmware Version: p821a10v1.0.0b06.LOG_DL

1.4 Environmental Variables:
Device: Flame 1.4 MOZ
BuildID: 20140522000200
Gaia: 233dd43b3b976e66a619dbc1b4044ed1e3ca3e34
Gecko: c3c0c57daef8
Version: 30.0
Firmware Version: v10e

2.0 Environmental Variables:
Device: Flame 2.0 MOZ
BuildID: 20140522040230
Gaia: ef66efa34ed8a559c8998bde688fae88eb943a7a
Gecko: b40296602083
Version: 32.0a1
Firmware Version: v10e