1008167 - Using access key which is in use multiple times doesn't activate/deactivate the underlying setting

Status: RESOLVED WORKSFORME

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Currently some accesskeys are duplicated. See bug 1008165. Usually that should be avoided, if there is really no other option, pressing the accesskey multiple times should switch through those elements. Currently that does not happen, even not the first element with that key gets selected.

Steps:
1. Open about:preferences
2. Go to privacy
3. Press Shift+Alt+t multiple times to enable/disable the appropriate settings

Nothing happens as of now.

Comment 1

[Dão Gottwald [:dao]]

(In reply to Henrik Skupin (:whimboo) from comment #0)
> Currently some accesskeys are duplicated. See bug 1008165. Usually that
> should be avoided, if there is really no other option, pressing the
> accesskey multiple times should switch through those elements.

This is not feasible. Pressing accesskeys doesn't only move focus, it activates items where applicable.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Dão Gottwald [:dao] from comment #1)
> This is not feasible. Pressing accesskeys doesn't only move focus, it
> activates items where applicable.

Well, even if that is not the case, we still have a problem here. As said above if the same key is used multiple times it doesn't have an effect at all. Even if it should enable/disable the first item with that access key only. Updating the wording to reflect that better.

Comment 3

[Dão Gottwald [:dao]]

If there were two items using the same access keys, the user looked at the second one, attempted to activate it and surprisingly activated the first item, that would be bad. So if we want to change the behavior such that the first item using a duplicated access key will be activated, we'll also need to make sure that the access key is exposed exclusively on that item.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Removing from blocking since the severity is low and the frequency of occurrence is low.

Comment 5

[James Teh [:Jamie]]

I can't reproduce this. If I press shift+alt+t in Privacy Settings as per comment 0, focus cycles between the controls with the duplicate access key, which is what I would expect.