1008241 - Put ccache on SSDs

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Chris AtLee [:catlee]]

It's likely that a lot of our IO on EBS is for the local ccache. Let's move that off of EBS onto SSD wherever possible.

Comment 1

[Massimo Gervasini [:massimo]]

Attachment: [puppet] Bug 1008241 - Put ccache on SSDs.patch

This patch moves the /builds/ccache directory to the instance storage (and mounts it), adding a new entry in fstab:

<instance_storage_mount_point>/ccache /builds/ccache none bind,noatime 0 0

Comment 2

[Chris AtLee [:catlee]]

Comment on attachment 8421824 [details] [diff] [review]
[puppet] Bug 1008241 - Put ccache on SSDs.patch

Review of attachment 8421824 [details] [diff] [review]:
-----------------------------------------------------------------

just a few nits.

::: modules/aws/files/manage_instance_storage.py
@@ +321,4 @@
>      """Updates /etc/fstab if needed"""
>      # example:
>      # /dev/sda / ext4 defaults,noatime  1 1
> +    #mount -o bind,noatime /builds/slave/ccache /builds/ccache/

left-over comment?

@@ +505,5 @@
> +        try:
> +            os.makedirs(ccache_dst)
> +            log.debug('created %s', ccache_dst)
> +        except OSError, error:
> +            log.debug('cannot create %s: %s', ccache_dst, error)

if this fails, we should probably abort

Comment 3

[Massimo Gervasini [:massimo]]

Attachment: [puppet] Bug 1008241 - Put ccache on SSDs.patch

Hi Chris,

this patch updates how CCACHE_DIR is mounted

Comment 4

[Massimo Gervasini [:massimo]]

Attachment: [puppet] Bug 1008241 - Put mock_mozilla on SSDs.patch

Hi Chris,

this patch moves mock_mozilla dir to the instance storage and prevents duplicate entries in /etc/fstab when an instance moves in/out from a jacuzzi pool.

Comment 5

[Massimo Gervasini [:massimo]]

Attachment: [puppet] Bug 1008241 - Put mock_mozilla on SSDs.patch

Hi catlee,

Bug 1011257 has made some changes on manage_instance_storage.py it's probably better to have another review.

Thanks

Comment 6

[Rail Aliiev [:rail]]

hmm, looks like we are missing group uid bit on mock_mozilla directory

new: drwxr-xr-x    2 root   mock_mozilla  4096 May 20  2014 mock_mozilla
old: drwxrwsr-x   5 root   mock_mozilla  4096 May 20 12:22 mock_mozilla

Comment 7

[Rail Aliiev [:rail]]

Attachment: chmod.diff

Comment 8

[Rail Aliiev [:rail]]

(In reply to Rail Aliiev [:rail] from comment #7)
> Created attachment 8425801 [details] [diff] [review]
> chmod.diff

I'm off on Wed (and maybe Thu). mgerva, can you take care of deploying this patch if it passes catlee's review please.

Comment 9

[Chris AtLee [:catlee]]

Comment on attachment 8425801 [details] [diff] [review]
chmod.diff

Review of attachment 8425801 [details] [diff] [review]:
-----------------------------------------------------------------

would work for now, but I think being completely explicit is better:

chmod 2775 <dirname>

(TIL about using = for chmod bits!)

Comment 10

[Massimo Gervasini [:massimo]]

Comment on attachment 8425801 [details] [diff] [review]
chmod.diff

replaced "g=rwxs" with "2775"