Closed
Bug 1008875
Opened 11 years ago
Closed 11 years ago
[NFC] Cleanup NFC command parser in emulator
Categories
(Firefox OS Graveyard :: NFC, defect)
Tracking
(b2g-v2.0 fixed)
RESOLVED
FIXED
2.0 S2 (23may)
| Tracking | Status | |
|---|---|---|
| b2g-v2.0 | --- | fixed |
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
Attachments
(1 file)
The emulator's console parses several arguments for each NFC command. Several commands share common arguments. The parser code for such commands should be unified and shared.
|
Assignee | |
Updated•11 years ago
|
OS: Linux → Gonk (Firefox OS)
Blocks: b2g-nfc
|
|
Assignee | |
Comment 1•11 years ago
|
||
This change set moves console-parser code into separate functions and fixes some minor bugs in the process.
Attachment #8421612 -
Flags: review?(vyang)
|
||
Updated•11 years ago
|
Attachment #8421612 -
Flags: review?(vyang) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8421612 [details]
Github pull request
Updated pull request
- cleaned up parse_sap, as suggested by comment
- introduced common lexer and parser functions
Vicamo, you might want to take another look, or please merge the change set if you're with it.
|
|
Assignee | |
Comment 3•11 years ago
|
||
"you're ok"
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-b2g-v2.0:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S2 (23may)
You need to log in
before you can comment on or make changes to this bug.
Description
•