Extraneous include's introduce unwanted dependencies

VERIFIED FIXED in mozilla0.9.6

Status

()

Core
HTML: Parser
P3
normal
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: Jon Smirl, Assigned: Jon Smirl)

Tracking

Trunk
mozilla0.9.6
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fix in hand])

Attachments

(1 attachment)

(Assignee)

Description

17 years ago
Unnecessary includes in htmlparser files...
#include "nsIXMLContentSink.h"
#include "nsITextContent.h"

cause unnecessary module dependencies
nkcache
widget
raptor
content

Removing includes removes dependecies
(Assignee)

Comment 1

17 years ago
Created attachment 50208 [details] [diff] [review]
remove include and fix dependencies
(Assignee)

Updated

17 years ago
Blocks: 100107

Comment 2

17 years ago
Comment on attachment 50208 [details] [diff] [review]
remove include and fix dependencies

nice! sr=alecf

Updated

17 years ago
Attachment #50208 - Flags: superreview+

Comment 3

17 years ago
Comment on attachment 50208 [details] [diff] [review]
remove include and fix dependencies

r=harishd
Attachment #50208 - Flags: review+

Updated

17 years ago
QA Contact: bsharma → moied

Updated

17 years ago
Status: NEW → ASSIGNED
Priority: -- → P3
Whiteboard: [fix in hand]
Target Milestone: --- → mozilla0.9.5

Comment 4

17 years ago
Who wants to checkin this puppy?

Comment 5

17 years ago
--> 0.9.6
Target Milestone: mozilla0.9.5 → mozilla0.9.6

Comment 6

17 years ago
just checked in the patch.. reassigning to jonsmirl to be marked fixed. Thanks jon!
Assignee: harishd → jonsmirl
Status: ASSIGNED → NEW

Comment 7

17 years ago
marking fixed.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
To fix bustage I had to add the nkcache back into the REQUIRES line. 
nsParser.cpp includes nsICacheEntryDescriptor.h.
... and the reason you didn't catch that is that you compiled on Windows, where
cache is not its own module (bug 103988).
(Assignee)

Comment 10

17 years ago
I just pulled and built and had trouble with this.

content is out of the makefile like it should be but this is still in:

===================================================================
RCS file: /cvsroot/mozilla/htmlparser/src/nsWellFormedDTD.cpp,v
retrieving revision 3.88
diff -u -r3.88 nsWellFormedDTD.cpp
--- mozilla/htmlparser/src/nsWellFormedDTD.cpp	2001/09/08 18:37:19	3.88
+++ mozilla/htmlparser/src/nsWellFormedDTD.cpp	2001/09/21 04:37:08
@@ -35,7 +35,6 @@
 #include "nsDTDUtils.h"
 #include "nsIContentSink.h"
 #include "nsIHTMLContentSink.h"
-#include "nsIXMLContentSink.h"
 #include "nsHTMLTokenizer.h"
 #include "nsExpatTokenizer.h"
 
which makes me need content. XMLContentSink is not used (at least on windows it 
isn't). The makefile is right and XMLContentSink should be removed.
Jon: that file's on the svg branch now, which is why it didn't show up. And I'd
merged 5 minutes before... Fixed now.

Comment 12

17 years ago
thanks to dbaron for catching that. I'm making nkcache a real module on windows
so I don't bust in the future :)

Comment 13

17 years ago
verified fix checked in cvs (rev 3.90)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.