Unnecessary includes in htmlparser files... #include "nsIXMLContentSink.h" #include "nsITextContent.h" cause unnecessary module dependencies nkcache widget raptor content Removing includes removes dependecies
Comment on attachment 50208 [details] [diff] [review] remove include and fix dependencies nice! sr=alecf
Comment on attachment 50208 [details] [diff] [review] remove include and fix dependencies r=harishd
Attachment #50208 - Flags: review+
Status: NEW → ASSIGNED
Priority: -- → P3
Whiteboard: [fix in hand]
Target Milestone: --- → mozilla0.9.5
Who wants to checkin this puppy?
Target Milestone: mozilla0.9.5 → mozilla0.9.6
just checked in the patch.. reassigning to jonsmirl to be marked fixed. Thanks jon!
Assignee: harishd → jonsmirl
Status: ASSIGNED → NEW
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
To fix bustage I had to add the nkcache back into the REQUIRES line. nsParser.cpp includes nsICacheEntryDescriptor.h.
... and the reason you didn't catch that is that you compiled on Windows, where cache is not its own module (bug 103988).
I just pulled and built and had trouble with this. content is out of the makefile like it should be but this is still in: =================================================================== RCS file: /cvsroot/mozilla/htmlparser/src/nsWellFormedDTD.cpp,v retrieving revision 3.88 diff -u -r3.88 nsWellFormedDTD.cpp --- mozilla/htmlparser/src/nsWellFormedDTD.cpp 2001/09/08 18:37:19 3.88 +++ mozilla/htmlparser/src/nsWellFormedDTD.cpp 2001/09/21 04:37:08 @@ -35,7 +35,6 @@ #include "nsDTDUtils.h" #include "nsIContentSink.h" #include "nsIHTMLContentSink.h" -#include "nsIXMLContentSink.h" #include "nsHTMLTokenizer.h" #include "nsExpatTokenizer.h" which makes me need content. XMLContentSink is not used (at least on windows it isn't). The makefile is right and XMLContentSink should be removed.
Jon: that file's on the svg branch now, which is why it didn't show up. And I'd merged 5 minutes before... Fixed now.
thanks to dbaron for catching that. I'm making nkcache a real module on windows so I don't bust in the future :)
verified fix checked in cvs (rev 3.90)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.