103988 - cache is not its own module for windows REQUIRES

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

In the autoconf build system, cache is its own MODULE (nkcache), but on Windows
it's part of the necko module.  This makes editing REQUIRES confusing and can
cause bustage when making the same change on different platforms (e.g., bug 100895).

Comment 1

[Alec Flett]

yeah, it's pretty strange. but it looks like the change is very simple, since
the windows REQUIRES lines already have "nkcache" listed...attaching a patch

Comment 2

[Alec Flett]

Attachment: switch from "necko" to "nkcache"

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 52917 [details] [diff] [review]
switch from "necko" to "nkcache"

r=dbaron if you've checked that it builds in a clobber build (and that the purge
script worked so the headers aren't still in dist/include/necko)

Comment 4

[Alec Flett]

I'll be trying a clobber build tonight.. adding [e-mail], added the wrong
one before

Comment 5

[hacker formerly known as [e-mail]]

r=cls

Comment 6

[Alec Flett]

checked in.