1008987 - [Contacts][Merger] Thumbnail on contacts list disappear when importing same vCard/.vcf file several times

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Michał Budzyński (:michalbe)]

**DESCRIPTION**
When we have a contact with photo as a Vcard on the SD card and import it several times there is no photo thumbnail on the contacts list.

**PATH**
1) export/put VCard file with contact that contains photo to the SD Card
2) remove the contact from your Contacts App
3) go to settings -> import -> import form SD Card
4) Get back to the contact list
5) Check if contact was importet properly
6) Repeat (3) & (4)

**EXPECTED**
Contact on the contacts list still looks the same 

**ACTUAL**
Contact on the contact list has no thumbnail, but still has  a photo in contacts details. When we will try (3) & (4) for the 3rd time, background merge will not recognize this contact as a duplicate, and will add it to the contacts list as a separate contact, with proper thumbnail. Going to contact details -> find duplicates will crash the Contacts App with an error:

JS ERROR at about:neterror?e=fileNotFound&u=app%3A//communications.gaiamobile.org/contacts/null&c=UTF-8&f=regular&m=app%3A//communications.gaiamobile.org/manifest.webapp&d=Firefox%20can%27t%20find%20the%20file%20at%20app%3A//communications.gaiamobile.org/contacts/null.:1226 in initPage: net-error

Comment 1

[Michał Budzyński (:michalbe)]

I was able to reproduce with 100% rate on todays master - ae15cfb697cc9127f9b909a5ba911186157f617c

Comment 2

[Jose Manuel Cantera]

Michal,

Are you actively working on a patch for this?

thanks

Comment 3

[Michał Budzyński (:michalbe)]

I'm not so far, feel free to take it.

Comment 4

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Hi Jose, 
would you mind reviewing the patch?
Regards

Comment 5

[Michał Budzyński (:michalbe)]

Marina, could you please check Bug 1015094 as well - I feel the issue there could be similar. Thanks.

Comment 6

[Jose Manuel Cantera]

Comment on attachment 8437682 [details] [review]
patch v1.0

Thanks Marina,

Please land once Travis is green

Comment 7

[Jose Manuel Cantera]

We don't have Flame devices yet. I would suggest once this bug lands that Sergi checks

Comment 8

[Marina Rodríguez [:mai]]

Master:6b5be16c8d1fd78936f05ce786a9cfd2eff38b2e

Comment 10

[Coler]

This issue has been verified successfully on Flame2.1.
Reproducing rate: 0/5
See attachment: Verify_Flame_Contact.mp4

Flame2.1 build version:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141202001201
Version         34.0

Comment 11

[Coler]

Attachment: Verify_Flame_Contact.MP4

Comment 12

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.1.

Result: The thumbnail on the contact list remains properly when the same contact is imported multiple times.

Device: Flame 2.1 (319mb, KK, Full Flash)
BuildID: 20141205001201
Gaia: 38e17b0219cbc50a4ad6f51101898f89e513a552
Gecko: 8b92c4b8f59a
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 13

[Josh Cheng [:josh]]

Hi Kai-Zhen,
2.0M+. Thanks!

Comment 14

[Kai-Zhen Li [:seinlin][:kli]]

v2.0m: https://github.com/mozilla-b2g/gaia/commit/c79551e20497acf732394504f3904477b0ec8edb

Comment 15

[Shine(Leave from Mozilla)]

Attachment: Woodduck Verify Video

This problem is verified not to happen on Woodduck2.0.
See attachment: Woodduck_verify_video.MP4
Occurrence rate: 0/10

Woodduck 2.0 build:
Gaia-Rev        add38992bbfb2bafca52ac1ce7f6231ac702675f
Gecko-Rev       8d951d9c4988e218ec08c6118a35c7faeb70af49
Build-ID        20141225143517
Version         32.0