1009042 - caps/tests/mochitest/test_bug995943.xul connects to non-local domain example.net

Status: RESOLVED FIXED

(Core :: Security: CAPS, defect)

Description

[Nathan Froyd [:froydnj]]

With the patches for bug 995417 applied:

07:45:25     INFO -  [970] WARNING: Non-local hostname example.net resolved: file /builds/slave/try-osx64-d-000000000000000000/build/netwerk/dns/nsHostResolver.cpp, line 1193
07:45:25     INFO -  BAD CONNECT: connecting to example.net 0
07:45:25     INFO -  Hit MOZ_CRASH(Attempting to connect to non-local address!) at /builds/slave/try-osx64-d-000000000000000000/build/netwerk/base/src/nsSocketTransport2.cpp:1189
07:45:49     INFO -  nsSocketEvent::Run() [netwerk/base/src/nsSocketTransport2.cpp:82]
07:45:49     INFO -  nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:715]
07:45:49     INFO -  NS_ProcessNextEvent(nsIThread*, bool) [xpcom/glue/nsThreadUtils.cpp:263]
07:45:49     INFO -  nsSocketTransportService::Run() [netwerk/base/src/nsSocketTransportService2.cpp:745]
07:45:49     INFO -  _ZThn24_N24nsSocketTransportService3RunEv [/var/folders/c9/0vh3194x3w1crzkp2xdydcp800000w/T/tmpFuXAHl.cpp:781]
07:45:49     INFO -  nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:715]
07:45:49     INFO -  NS_ProcessNextEvent(nsIThread*, bool) [xpcom/glue/nsThreadUtils.cpp:263]
07:45:49     INFO -  mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:336]
07:45:49     INFO -  MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:504]
07:45:49     INFO -  nsThread::ThreadFunc(void*) [xpcom/threads/nsThread.cpp:325]
07:45:50     INFO -  _pt_root
07:45:50     INFO -  libSystem.B.dylib + 0x39fd6
07:45:50     INFO -  TEST-INFO | Main app process: killed by SIGHUP

I guess we finally need to add example.net to our server-locations.txt.  Or change the name used by the test.  I don't particularly care which happens.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: add example.net to server-locations.txt

example.net is a valid "example" domain, like example.com and example.net.  We
should just include it as one of our known servers.

Comment 2

[Nathan Froyd [:froydnj]]

(In reply to Nathan Froyd (:froydnj) from comment #1)
> example.net is a valid "example" domain, like example.com and example.net. 

Uh, example.org.  Yeah, that's the one....

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8421080 [details] [diff] [review]
add example.net to server-locations.txt

Review of attachment 8421080 [details] [diff] [review]:
-----------------------------------------------------------------

why not change the test to go to example.com?  This approach is fine as well.

Comment 4

[Nathan Froyd [:froydnj]]

(In reply to Joel Maher (:jmaher) from comment #3)
> Comment on attachment 8421080 [details] [diff] [review]
> add example.net to server-locations.txt
> 
> Review of attachment 8421080 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> why not change the test to go to example.com?  This approach is fine as well.

The test uses example.com and example.org as "domains you are permitted to access" and example.net as a "domain you are not permitted to access".  Changing it to something else besides example.net that's supported by server-locations.txt would would just as well.

Modifying server-locations.txt has the side benefit of addressing bug 998298, and doesn't require waiting for those test fixes to be backported from upstream.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

ok, that is just fine!

Comment 6

[Bobby Holley (:bholley)]

Oh yeah, this is bad. This might explain bug 995943.

Setting this as blocking bug 995943, so that we can make sure to backport this when we backport that bug.

Comment 7

[Nathan Froyd [:froydnj]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/81275dbd89cb

Comment 8

[Bobby Holley (:bholley)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a37d3956b8c6
https://hg.mozilla.org/releases/mozilla-beta/rev/913fb15c7218

Backported this along with bug 995943.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/913fb15c7218

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/81275dbd89cb