Closed Bug 1009042 Opened 6 years ago Closed 6 years ago

caps/tests/mochitest/test_bug995943.xul connects to non-local domain example.net

Categories

(Core :: Security: CAPS, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32
Tracking Status
firefox30 --- fixed
firefox31 --- fixed
firefox32 --- fixed
firefox-esr24 --- unaffected
b2g-v1.2 --- unaffected
b2g-v1.3 --- unaffected
b2g-v1.3T --- unaffected
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(1 file)

With the patches for bug 995417 applied:

07:45:25     INFO -  [970] WARNING: Non-local hostname example.net resolved: file /builds/slave/try-osx64-d-000000000000000000/build/netwerk/dns/nsHostResolver.cpp, line 1193
07:45:25     INFO -  BAD CONNECT: connecting to example.net 0
07:45:25     INFO -  Hit MOZ_CRASH(Attempting to connect to non-local address!) at /builds/slave/try-osx64-d-000000000000000000/build/netwerk/base/src/nsSocketTransport2.cpp:1189
07:45:49     INFO -  nsSocketEvent::Run() [netwerk/base/src/nsSocketTransport2.cpp:82]
07:45:49     INFO -  nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:715]
07:45:49     INFO -  NS_ProcessNextEvent(nsIThread*, bool) [xpcom/glue/nsThreadUtils.cpp:263]
07:45:49     INFO -  nsSocketTransportService::Run() [netwerk/base/src/nsSocketTransportService2.cpp:745]
07:45:49     INFO -  _ZThn24_N24nsSocketTransportService3RunEv [/var/folders/c9/0vh3194x3w1crzkp2xdydcp800000w/T/tmpFuXAHl.cpp:781]
07:45:49     INFO -  nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:715]
07:45:49     INFO -  NS_ProcessNextEvent(nsIThread*, bool) [xpcom/glue/nsThreadUtils.cpp:263]
07:45:49     INFO -  mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:336]
07:45:49     INFO -  MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:504]
07:45:49     INFO -  nsThread::ThreadFunc(void*) [xpcom/threads/nsThread.cpp:325]
07:45:50     INFO -  _pt_root
07:45:50     INFO -  libSystem.B.dylib + 0x39fd6
07:45:50     INFO -  TEST-INFO | Main app process: killed by SIGHUP

I guess we finally need to add example.net to our server-locations.txt.  Or change the name used by the test.  I don't particularly care which happens.
example.net is a valid "example" domain, like example.com and example.net.  We
should just include it as one of our known servers.
Attachment #8421080 - Flags: review?(jmaher)
(In reply to Nathan Froyd (:froydnj) from comment #1)
> example.net is a valid "example" domain, like example.com and example.net. 

Uh, example.org.  Yeah, that's the one....
Comment on attachment 8421080 [details] [diff] [review]
add example.net to server-locations.txt

Review of attachment 8421080 [details] [diff] [review]:
-----------------------------------------------------------------

why not change the test to go to example.com?  This approach is fine as well.
Attachment #8421080 - Flags: review?(jmaher) → review+
(In reply to Joel Maher (:jmaher) from comment #3)
> Comment on attachment 8421080 [details] [diff] [review]
> add example.net to server-locations.txt
> 
> Review of attachment 8421080 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> why not change the test to go to example.com?  This approach is fine as well.

The test uses example.com and example.org as "domains you are permitted to access" and example.net as a "domain you are not permitted to access".  Changing it to something else besides example.net that's supported by server-locations.txt would would just as well.

Modifying server-locations.txt has the side benefit of addressing bug 998298, and doesn't require waiting for those test fixes to be backported from upstream.
ok, that is just fine!
Oh yeah, this is bad. This might explain bug 995943.

Setting this as blocking bug 995943, so that we can make sure to backport this when we backport that bug.
Blocks: 995943
No longer depends on: 995943
Blocks: 1008481
http://hg.mozilla.org/integration/mozilla-inbound/rev/81275dbd89cb
Assignee: nobody → nfroyd
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/81275dbd89cb
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.