1009065 - Rocketbar doesn't use full width when focused / in edit mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[William Dorffer [:Nildeala]]

Attachment: 2014-05-12-20-17-07.png

Since 997920 has landed, Rocketbar isn't as wide as it is supposed to be, according to the spec, when it is focused and the "cancel" button shows up.
I'm attaching a screenshot.

Comment 1

[Ben Francis [:benfrancis]]

Hi William,

Can you provide a little more information about how to reproduce this bug?

What version of Gecko and Gaia are you using, and on what device?

Comment 2

[William Dorffer [:Nildeala]]

Hi Ben,
This happens since bug 997920 has landed on master (b2g 2.0). I'm running master branch on a Geeksphone Peak (qHD screen device then), and as this screenshot was taken both gaia and gecko were built on 11/05/2014.

Comment 3

[William Dorffer [:Nildeala]]

Also, reproducing the bug is as simple as touching Rocketbar so as to be able to type in it.

Comment 4

[Dale Harvey (:daleharvey)]

I noticed this on the nexus 4 as well

Comment 5

[Ben Francis [:benfrancis]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/19545

Comment 6

[Dale Harvey (:daleharvey)]

Comment on attachment 8426989 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/19545

Looks good

I am going to an effort to be good and only land on green patches, although the failure was unrelated, will land when I see this is green, cheers

Comment 7

[Dale Harvey (:daleharvey)]

green

landed in: https://github.com/mozilla-b2g/gaia/commit/1913ca75a21e1290a753d3ec5fcca9b56f214270

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/faa1c189f23b