1009408 - IAC shouldn't check the install origin for certified apps

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gene Lian (I already quit Mozilla)]

The certified app doesn't have an install origin, so the IAC shouldn't check if it matches the rules.

Comment 1

[Gene Lian (I already quit Mozilla)]

Attachment: Part 1, remove the install origin check in Gaia UI test

I'd like to remove the install origin check in the Gaia UI test because both the publisher and subscriber apps are certified, which means the |installOrigins| won't actually work for them. Since the IAC is exposed to certified apps only so the test is actually enough for now.

Note that we need to land the Gaia part first and then we can land the Gecko part to ensure the backward compatibility.

Comment 2

[Gene Lian (I already quit Mozilla)]

Attachment: Part 2, remove the install origin check in Gecko

It doesn't make sense to match the install origin for certified apps because they don't have ones, so I'd like remove the logic to meet what's said in the spec [1]:

  "Since certified apps has not a valid install origin, these constraint does not apply to them."

[1] https://wiki.mozilla.org/WebAPI/Inter_App_Communication_Alt_proposal

Comment 3

[Gene Lian (I already quit Mozilla)]

There are going to be some conflicts with bug 951246. Will rebase this tomorrow.

Thanks Fernando for the review!

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/7e0457a3c86194f36c286ca068428cf488476df7

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/f3a2dab22eed

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f3a2dab22eed