Closed Bug 1009444 Opened 6 years ago Closed 6 years ago

[Stingray] initialize widgets based on the result of widget editor

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: johnhu, Assigned: johnhu)

References

Details

(Whiteboard: [FT:Stream3])

Attachments

(1 file, 1 obsolete file)

This issue tracks:
1. Homescreen app loads widgets when it starts up.
2. Homescreen app updates widgets when user change the configuration through widget editor.
Depends on: 1002341, 1002343
Assignee: nobody → johu
Attached patch WIP patch (obsolete) — Splinter Review
Since we depend on other bugs, this is a WIP based on those bugs' patch.
Attached file patch for this bug
I had finished this patch please review it.
Attachment #8424716 - Attachment is obsolete: true
Attachment #8425254 - Flags: review?(tzhuang)
Attachment #8425254 - Flags: review?(lchang)
Attachment #8425254 - Flags: review?(gchen)
Comment on attachment 8425254 [details] [review]
patch for this bug

Thanks for the patch.

r+ with nits, please see github comments.
Attachment #8425254 - Flags: review?(tzhuang) → review+
Comment on attachment 8425254 [details] [review]
patch for this bug

It looks good to me, too! Thanks!
Attachment #8425254 - Flags: review?(lchang) → review+
merged to master:
https://github.com/mozilla-b2g/gaia/commit/e3d0d9d6ba9b1634fa943cfe514fab4e7626c83b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [FT:Stream3]
You need to log in before you can comment on or make changes to this bug.