1002341 - [Stingray] widget editor implementation

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

The widget editor is a UI for user to customize their widgets. In stingray, we may have a dedicated UI for user to customize the position of widgets.

ref: https://wiki.mozilla.org/FirefoxOS/Stingray/Hybrid_Widget_Approach#Widget_Editor

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

Depends on bug 1002350 because it needs spatial navigation and selection border.

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

This bug totally depends on bug 1002344 which is a meta bug of bug 1002350.

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: patch for this bug

Hi all,

Please review this patch. Most of this patch are unit tests and mock objects. Once bug 1002358 landed, some of them may be removed because they are duplicated.

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8422239 [details] [review]
patch for this bug

switch review flag to gary since rex is busy on another topic.

Comment 5

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Comment on attachment 8422239 [details] [review]
patch for this bug

I've left some comment but overall is good for me!
Give feeback+ first since I am out of office on this Fri,
I can't review it again.
Please discuss with Luke and wait for his review.

Thanks, nice work.

Comment 6

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8422239 [details] [review]
patch for this bug

Great work! Thanks.

Comment 7

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8422239 [details] [review]
patch for this bug

looks good to me, thanks

Comment 8

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/fde99f0f0998049d9e512a5151d7aa1ee79b97a0