1009780 - Improve download opening mechanism

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[[:fabrice] Fabrice Desré]

The download manager currently uses the mimeMapper helper to decides if a downloaded file can be opened. That prevents us to use 3rd party apps that would provide support for new mime types to work.

Instead, we should just trigger an activity with the mime type and the blob. Among the core apps, pdf.js needs to be updated to also deal with blobs and not only uris.

Once this is done we'll remove the gecko side registration of activities as content handlers.

Comment 1

[Aus Lacroix [:aus]]

Attachment: Pull Request - Improve 'open' mechnism for downloads

:crdlc, could you look at the DownloadHelper changes?

:bdahl, could you look at the PDFJS viewer.js changes? I'm running into a crash on my Flame using this PDF (http://fzs.sve-mo.ba/sites/default/files/dokumenti-vijesti/sample.pdf) although, viewing *any* PDF on the Flame seems to crash.

Comment 2

[Yury Delendik (:yury)]

Comment on attachment 8436050 [details] [review]
Pull Request - Improve 'open' mechnism for downloads

 apps/pdfjs/content/web/viewer.js looks good

Comment 3

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8436050 [details] [review]
Pull Request - Improve 'open' mechnism for downloads

Some minor nits, but LGTM r+, 10x

Comment 4

[Aus Lacroix [:aus]]

Commit (master): https://github.com/mozilla-b2g/gaia/commit/3553e4fed932419b957e083fdda441358e4eb834

Fixed!

Comment 5

[Jason Smith [:jsmith]]

Aus - Do we need to make the pdfjs changes seen in this commit also in https://github.com/mozilla/pdf.js/?

Comment 6

[Aus Lacroix [:aus]]

(In reply to Jason Smith [:jsmith] from comment #5)
> Aus - Do we need to make the pdfjs changes seen in this commit also in
> https://github.com/mozilla/pdf.js/?

Yes, the change will also be uplifted to the main pdf.js repository.

Comment 7

[yifan [:yifan][:yliao]]

Comment on attachment 8436050 [details] [review]
Pull Request - Improve 'open' mechnism for downloads

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):Bug 1046531 - [Dolphin][v1.4] Cannot open PDF file
[User impact] if declined: Extra works for supporting downloaded items with various file extensions.
[Testing completed]:https://tbpl.mozilla.org/?rev=ace8d73b222fdf924a19e78f9a39b60ab03b6010&tree=Gaia-Try
[Risk to taking this patch] (and alternatives if risky): None
[String changes made]:

Comment 8

[Preeti Raghunath(:Preeti)]

(In reply to Yi-Fan Liao [:yifan][:yliao] from comment #7)
> Comment on attachment 8436050 [details] [review]
> Pull Request - Improve 'open' mechnism for downloads
> 
> NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to
> better understand the B2G approval process and landings.
> 
> [Approval Request Comment]
> [Bug caused by] (feature/regressing bug #):Bug 1046531 - [Dolphin][v1.4]
> Cannot open PDF file
> [User impact] if declined: Extra works for supporting downloaded items with
> various file extensions.
> [Testing
> completed]:https://tbpl.mozilla.org/
> ?rev=ace8d73b222fdf924a19e78f9a39b60ab03b6010&tree=Gaia-Try
> [Risk to taking this patch] (and alternatives if risky): None
> [String changes made]:

What about making any string changes?

Comment 9

[yifan [:yifan][:yliao]]

[String changes made]: N/A

No string change is made. Sorry about missing it. :)

Comment 11

[Evelyn Hung]

[Blocking Requested - why for this release]:
Given bug 1046531 is 1.4+, could we make it a blocker so we won't lose tracking?

Comment 12

[Wayne Chang [:wchang]]

Thank you Evelyn.

per comment 11 and bug 1046531 - a feature is broken on 1.4.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/6f3f3da0b56cdc08aafdcab96ce9be03076b9c2c