Closed Bug 1010028 Opened 10 years ago Closed 10 years ago

mach: Set args properly for various debuggers

Categories

(Firefox Build System :: Mach Core, enhancement)

x86
macOS
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla32

People

(Reporter: TYLin, Assigned: TYLin)

References

Details

Attachments

(1 file, 1 obsolete file)

If both gdb and lldb are installed on the system, "mach debug +debugger lldb -p nightly" will not add "--" argument properly. Also, it will be more convenient to add "--args" automatically for gdb front-end such as cgdb or ddd.
Assignee: nobody → tlin
Summary: Set default debugparams properly for various debuggers → mach: Set args properly for various debuggers
Set args properly to to separate the debugger and process arguments.
Also add "--args" automatically for gdb front-end cgdb and ddd.

Varification Steps:
1. mach debug +debugger gdb
2. Make sure gdb is launched correctly.
Attachment #8422177 - Flags: review?(gps)
Attachment #8422177 - Flags: review?(gps) → review?(mh+mozilla)
Hi Mike,

Would you help review this change? Thank.

Try results:
https://tbpl.mozilla.org/?tree=Try&rev=ed17dabb1e68
Comment on attachment 8422177 [details] [diff] [review]
Set args properly for various debuggers

Review of attachment 8422177 [details] [diff] [review]:
-----------------------------------------------------------------

"Varification" typo in the changeset message.
Attachment #8422177 - Flags: review?(mh+mozilla) → review+
Fix typo in the changeset message.

Mike, thanks for reviewing!
Attachment #8422177 - Attachment is obsolete: true
Attachment #8425181 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/34e5373ef68d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: