1010028 - mach: Set args properly for various debuggers

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

If both gdb and lldb are installed on the system, "mach debug +debugger lldb -p nightly" will not add "--" argument properly. Also, it will be more convenient to add "--args" automatically for gdb front-end such as cgdb or ddd.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Set args properly for various debuggers

Set args properly to to separate the debugger and process arguments.
Also add "--args" automatically for gdb front-end cgdb and ddd.

Varification Steps:
1. mach debug +debugger gdb
2. Make sure gdb is launched correctly.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Hi Mike,

Would you help review this change? Thank.

Try results:
https://tbpl.mozilla.org/?tree=Try&rev=ed17dabb1e68

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8422177 [details] [diff] [review]
Set args properly for various debuggers

Review of attachment 8422177 [details] [diff] [review]:
-----------------------------------------------------------------

"Varification" typo in the changeset message.

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Set args properly for various debuggers (v2)

Fix typo in the changeset message.

Mike, thanks for reviewing!

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/34e5373ef68d

Comment 6

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/mozilla-central/rev/34e5373ef68d