Closed
Bug 993243
Opened 10 years ago
Closed 10 years ago
Add a parameter to "mach debug" to specify the debugger to launch
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla31
People
(Reporter: roc, Assigned: roc)
References
Details
Attachments
(1 file)
4.01 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
This will make rr a bit easier to use with mach.
Assignee | ||
Comment 1•10 years ago
|
||
I don't understand why "mach debug" takes parameters of the form "+foobar" while other commands take parameters of the form "--foobar".
Attachment #8403049 -
Flags: review?(gps)
Comment 2•10 years ago
|
||
Comment on attachment 8403049 [details] [diff] [review] fix Review of attachment 8403049 [details] [diff] [review]: ----------------------------------------------------------------- The +args are because of some interaction between the Python argument parsing trying to interpret the arguments passed to Firefox e.g. -no-remote. I /think/ there is a better way to handle it. It might also be a mach issue. Patches welcome.
Attachment #8403049 -
Flags: review?(gps) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3aaa298ed2b
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f3aaa298ed2b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Comment 5•10 years ago
|
||
Comment on attachment 8403049 [details] [diff] [review] fix Review of attachment 8403049 [details] [diff] [review]: ----------------------------------------------------------------- ::: python/mozbuild/mozbuild/mach_commands.py @@ +847,5 @@ > > + if use_gdb: > + args.append('--args') > + elif use_lldb: > + args.append('--') If both gdb and lldb are installed on the system, user might want to pass either +debugger gdb or +debugger lldb. In this way, args will not be set properly.
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•