993243 - Add a parameter to "mach debug" to specify the debugger to launch

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This will make rr a bit easier to use with mach.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

I don't understand why "mach debug" takes parameters of the form "+foobar" while other commands take parameters of the form "--foobar".

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8403049 [details] [diff] [review]
fix

Review of attachment 8403049 [details] [diff] [review]:
-----------------------------------------------------------------

The +args are because of some interaction between the Python argument parsing trying to interpret the arguments passed to Firefox e.g. -no-remote.

I /think/ there is a better way to handle it. It might also be a mach issue. Patches welcome.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f3aaa298ed2b

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f3aaa298ed2b

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Comment on attachment 8403049 [details] [diff] [review]
fix

Review of attachment 8403049 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/mach_commands.py
@@ +847,5 @@
>  
> +        if use_gdb:
> +            args.append('--args')
> +        elif use_lldb:
> +            args.append('--')

If both gdb and lldb are installed on the system, user might want to pass either +debugger gdb or +debugger lldb. In this way, args will not be set properly.