1010212 - [Flame] Integrate libloc blobs to get GPS working

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[:gerard-majax]

Flashing my own system.img, GPS was not working.

It seems to be okay after pushing a couple of extracted blobs:
> adb push backup-flame/system/lib/libloc_eng.so  /system/lib/
> adb push backup-flame/system/lib/libloc_api_v02.so  /system/lib/
> adb push backup-flame/system/lib/libloc_core.so  /system/lib/
> adb push backup-flame/system/lib/libloc_ds_api.so  /system/lib/
> adb push backup-flame/system/lib/libloc_xtra.so  /system/lib/
> adb push backup-flame/system/lib/libgps.utils.so  /system/lib/

Comment 1

[:gerard-majax]

Attachment: Link to Github https://github.com/mozilla-b2g/device-flame/pull/19

Please find attached changes to the extract-files.sh to add those blobs.

Comment 2

[Michael Wu [:mwu]]

Comment on attachment 8422404 [details] [review]
Link to Github https://github.com/mozilla-b2g/device-flame/pull/19

r=me with the new entries alphabetized within the list.

Comment 3

[:gerard-majax]

(In reply to Michael Wu [:mwu] from comment #2)
> Comment on attachment 8422404 [details] [review]
> Link to Github https://github.com/mozilla-b2g/device-flame/pull/19
> 
> r=me with the new entries alphabetized within the list.

Of course. However, I had a closer look to other makefiles and to the hardware/qcom/gps directory, and it would seems those may not be blobs after all.

Comment 4

[:gerard-majax]

Okay it seems those sources needs other things from Qualcomm to build: libloc_api makes reference to "latest modem image" to build, and relies on BUILD_TINY_ANDROID being true. I'm not sure we can rebuild those sources at the moment.

Viral, do you know if we can sync with partners to get the needed bits ? The less blob we use, the better :)

Comment 5

[:gerard-majax]

PR udapted with the new entries sorted as requested in comment 2.

Flagging checkin-needed since I don't have privileges to merge :)

Comment 6

[Carsten Book [:Tomcat]]

(In reply to Alexandre LISSY :gerard-majax from comment #5)
> PR udapted with the new entries sorted as requested in comment 2.
> 
> Flagging checkin-needed since I don't have privileges to merge :)

np :) 

master: https://github.com/mozilla-b2g/device-flame/commit/1b3322cfd1179ea11fa5083d600717b65e5923e6

Comment 7

[:gerard-majax]

Enabling GPS debugging (bug 1011410), we see NMEA callbacks getting into gecko :)

Comment 8

[viral [:viralwang]]

Hi Alexandre,

libloc_api_v02.so looks like the proprietary to me.
I think there's no open source code for this?
Maybe you can tell me which repository if the code is open?

Comment 9

[:gerard-majax]

(In reply to viral [:viralwang] from comment #8)
> Hi Alexandre,
> 
> libloc_api_v02.so looks like the proprietary to me.
> I think there's no open source code for this?
> Maybe you can tell me which repository if the code is open?

Viral, you can find the sources of this code also in some subdirectories hardware/qcom/gps. But looking at the makefile, it seems to depends on modem image. So I'm not sure about the status.

Comment 10

[viral [:viralwang]]

Hi Alexandre,

There's a build flag "BUILD_TINY_ANDROID" in hardware/qcom/gps.
Normally we won't used it for entire build.

I search the gps relative config in folder "device"
device/qcom/common/common.mk:157:GPS_HARDWARE += libloc_api_v02

I believe there's a gps folder under vendor/qcom/proprietary but we can't get the source code to build.
That's why I think we should keep using blob to make gps works.

Comment 11

[:gerard-majax]

(In reply to viral [:viralwang] from comment #10)
> Hi Alexandre,
> 
> There's a build flag "BUILD_TINY_ANDROID" in hardware/qcom/gps.
> Normally we won't used it for entire build.
> 
> I search the gps relative config in folder "device"
> device/qcom/common/common.mk:157:GPS_HARDWARE += libloc_api_v02
> 
> I believe there's a gps folder under vendor/qcom/proprietary but we can't
> get the source code to build.
> That's why I think we should keep using blob to make gps works.

Yes, I sadly agree. In hardware/qcom/gps/loc_api/libloc_api_50001/Android.mk, there's a statement: "Compile this library only for builds with the latest modem image".