Closed
Bug 1010261
Opened 10 years ago
Closed 10 years ago
Add preference to enable/disable suggested sites
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 32
People
(Reporter: lucasr, Assigned: lucasr)
References
Details
Attachments
(2 files, 2 obsolete files)
4.02 KB,
patch
|
liuche
:
review+
|
Details | Diff | Splinter Review |
8.35 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Users should be able to disable the suggested sites feature if they want.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8426154 [details] [diff] [review] Add preferences UI for disabling suggested sites (r=liuche) Just the UI bits for preferences. Still need to discuss with dria/ibarlow about the working here. Will NI them in this bug.
Attachment #8426154 -
Flags: review?(liuche)
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Comment 5•10 years ago
|
||
dria, ibarlow, we need to decide on how we want to expose the on/off switch for suggested sites. My patch adds a checkbox preference under Customize -> Home -> Content Settings (Section). I'm wording it as "Show suggested sites". So, some questions for you: - Is 'Suggested sites' the right name for this feature? Maybe we'll have to align with desktop somehow? But let's not call it 'Directory Tiles', please... - We also need a little description (a 'summary' in Android terms) to go below the checkbox text to give more context about what this toggle actually does.
Assignee | ||
Updated•10 years ago
|
Attachment #8426155 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Attachment #8426156 -
Attachment is obsolete: true
Assignee | ||
Comment 6•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8426161 -
Flags: review?(mark.finkle)
Comment 7•10 years ago
|
||
Comment on attachment 8426161 [details] [diff] [review] Change SuggestedSites to account for enabled/disabled state (r=mfinkle) >diff --git a/mobile/android/base/db/SuggestedSites.java b/mobile/android/base/db/SuggestedSites.java >\ No newline at end of file Could you add a newline here? >diff --git a/mobile/android/base/preferences/GeckoPreferences.java b/mobile/android/base/preferences/GeckoPreferences.java >+ public static final String PREFS_SUGGESTED_SITES = NON_PREF_PREFIX + "home_suggested_sites"; We have another Home related pref and it uses "home.xxx_yyy", so lets keep them kinda the same. How about: "home.suggested_sites" http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/preferences/GeckoPreferences.java#95
Attachment #8426161 -
Flags: review?(mark.finkle) → review+
Comment 8•10 years ago
|
||
Comment on attachment 8426154 [details] [diff] [review] Add preferences UI for disabling suggested sites (r=liuche) >diff --git a/mobile/android/base/locales/en-US/android_strings.dtd b/mobile/android/base/locales/en-US/android_strings.dtd >+<!ENTITY pref_home_suggested_sites "Show suggested sites"> >+<!ENTITY pref_home_suggested_sites_summary "Something goes here..."> We have a setting for showing search suggestions that we *might* want to align the language/tone: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/locales/en-US/android_strings.dtd#171 "Show search suggestions" Would "Show site suggestions" be favorable? The two prefs would not be visible in the same settings group so we don't need to worry about that. I like "Show site suggestions" a little because it does not create a feature name. We have been calling these "Suggested Sites" but if we can avoid naming the feature I think it would be better for end users.
Assignee | ||
Comment 9•10 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #8) > Comment on attachment 8426154 [details] [diff] [review] > Add preferences UI for disabling suggested sites (r=liuche) > > >diff --git a/mobile/android/base/locales/en-US/android_strings.dtd b/mobile/android/base/locales/en-US/android_strings.dtd > > >+<!ENTITY pref_home_suggested_sites "Show suggested sites"> > >+<!ENTITY pref_home_suggested_sites_summary "Something goes here..."> > > We have a setting for showing search suggestions that we *might* want to > align the language/tone: > > http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/locales/en- > US/android_strings.dtd#171 > > "Show search suggestions" > > Would "Show site suggestions" be favorable? The two prefs would not be > visible in the same settings group so we don't need to worry about that. I > like "Show site suggestions" a little because it does not create a feature > name. We have been calling these "Suggested Sites" but if we can avoid > naming the feature I think it would be better for end users. +1.
Comment 10•10 years ago
|
||
Comment on attachment 8426154 [details] [diff] [review] Add preferences UI for disabling suggested sites (r=liuche) Review of attachment 8426154 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, with the change mfinkle suggested ("Show site suggestions"). ::: mobile/android/base/locales/en-US/android_strings.dtd @@ +115,5 @@ > <!ENTITY pref_home_updates "Automatic updates"> > <!ENTITY pref_home_updates_enabled "Enabled"> > <!ENTITY pref_home_updates_wifi "Only over Wi-Fi"> > +<!ENTITY pref_home_suggested_sites "Show suggested sites"> > +<!ENTITY pref_home_suggested_sites_summary "Something goes here..."> Just a reminder that we're not landing with this. We could leave it out and file a follow-up if we're in a hurry.
Attachment #8426154 -
Flags: review?(liuche) → review+
Assignee | ||
Comment 11•10 years ago
|
||
(In reply to Chenxia Liu [:liuche] from comment #10) > Comment on attachment 8426154 [details] [diff] [review] > Add preferences UI for disabling suggested sites (r=liuche) > > Review of attachment 8426154 [details] [diff] [review]: > ----------------------------------------------------------------- > > Looks good, with the change mfinkle suggested ("Show site suggestions"). > > ::: mobile/android/base/locales/en-US/android_strings.dtd > @@ +115,5 @@ > > <!ENTITY pref_home_updates "Automatic updates"> > > <!ENTITY pref_home_updates_enabled "Enabled"> > > <!ENTITY pref_home_updates_wifi "Only over Wi-Fi"> > > +<!ENTITY pref_home_suggested_sites "Show suggested sites"> > > +<!ENTITY pref_home_suggested_sites_summary "Something goes here..."> > > Just a reminder that we're not landing with this. We could leave it out and > file a follow-up if we're in a hurry. No hurry, I'll wait for ibarlow's feedback before landing :-)
Comment 12•10 years ago
|
||
"Suggested sites" seems like an ok thing to call this for now. I have a couple of versions of summary text we could try. I'm open to feedback here from Deb, Lucas, Mark :) # Show suggested sites [x] To help get you browsing faster, Firefox displays shortcuts to sites on your homepage that we think you might find interesting # Show suggested sites [x] Displays sites on your homepage that we think you might find interesting # Show suggested sites [x] Displays sites on your homepage that Mozilla thinks you might find interesting
Assignee | ||
Comment 13•10 years ago
|
||
After discussion with ibarlow on IRC, we went with: # Show site suggestions [x] Display shortcuts to sites on your homepage that we think you might find interesting Pushed: https://hg.mozilla.org/integration/fx-team/rev/edc59b60af2e https://hg.mozilla.org/integration/fx-team/rev/306c7252d8f7
https://hg.mozilla.org/mozilla-central/rev/edc59b60af2e https://hg.mozilla.org/mozilla-central/rev/306c7252d8f7
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
Flags: in-moztrap?(fennec)
Updated•10 years ago
|
QA Contact: ioana.chiorean
Comment 15•10 years ago
|
||
Moztrap TCs added: https://moztrap.mozilla.org/manage/case/13914/ https://moztrap.mozilla.org/manage/case/13915/
Flags: in-moztrap?(fennec) → in-moztrap+
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•