1249783 - Consider removing "Show site suggestions" pref in Settings > General > Home > Content settings

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

I noticed this the other day but wasn't sure why we had it... perhaps there's some history here that I could ask for? 

Show site suggestions
Display shortcuts to sites on your homepage that we think you might ind interesting  [ ] 

I think its supposed to remove the default suggested sites? But we changed to Alexa top 5 and that seems to address the same issue that this pref was designed to address?

So, it seems redundant since it's so tucked away, but also because long-press to remove a (now) Alexa Top 5 suggestion is infinitely easier.

This just seems complicated to understand and I'd like to simplify if we can.

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Mfinkle might know why this is here..

Comment 2

[:Margaret Leibovic]

It was added in bug 1010261, but there's not much context on that original bug. I think we could get rid of this.

Comment 3

[:Margaret Leibovic]

NI to Barbara to confirm that we should remove this.

Comment 4

[Barbara Bermes [:barbara] - NI please!]

Agreed, I also don't think we keep track of this feature in UI Telemetry, but I'd argue the usage is very low. So let's clean it up!

Out of curiosity, where would I find all the settings in code in case I would want to add some UI telemetry in there?

Comment 5

[:Margaret Leibovic]

(In reply to Barbara Bermes [:barbara] from comment #4)
> Agreed, I also don't think we keep track of this feature in UI Telemetry,
> but I'd argue the usage is very low. So let's clean it up!
> 
> Out of curiosity, where would I find all the settings in code in case I
> would want to add some UI telemetry in there?

The settings code is a bit of a nightmare, but the main class you want to look at is here: 
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferences.java

Here's a search for all the current UI telemetry probes we have in here:
http://mxr.mozilla.org/mozilla-central/search?find=%2Fmobile%2Fandroid%2Fbase%2Fjava%2Forg%2Fmozilla%2Fgecko%2Fpreferences%2F&string=telemetry.senduievent

Comment 6

[:Grisha Kruglov]

Attachment: MozReview Request: Bug 1249783 - remove ability to disable suggested sites (r=margaret)

Review commit: https://reviewboard.mozilla.org/r/38837/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38837/

Comment 7

[:Margaret Leibovic]

Comment on attachment 8728184 [details]
MozReview Request: Bug 1249783 - remove ability to disable suggested sites (r=margaret)

Redirecting this review to ahunt, since he's been working with suggested sites most recently.

Comment 8

[:Grisha Kruglov]

Comment on attachment 8728184 [details]
MozReview Request: Bug 1249783 - remove ability to disable suggested sites (r=margaret)

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38837/diff/1-2/

Comment 9

[:Grisha Kruglov]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0edddf8c86b2

Comment 10

[:Margaret Leibovic]

Comment on attachment 8728184 [details]
MozReview Request: Bug 1249783 - remove ability to disable suggested sites (r=margaret)

https://reviewboard.mozilla.org/r/38837/#review35677

Nice, this looks good to me. Let's make sure a try run passes, and then you can mark this bug with the "checkin-needed" keyword.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing.

Comment 12

[:Grisha Kruglov]

Comment on attachment 8728184 [details]
MozReview Request: Bug 1249783 - remove ability to disable suggested sites (r=margaret)

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38837/diff/2-3/

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/14c09980119b

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out in https://hg.mozilla.org/integration/fx-team/rev/7cca2abc09bb for 'Unit' test failures:

https://treeherder.mozilla.org/logviewer.html#?job_id=7951303&repo=fx-team

Comment 15

[:Grisha Kruglov]

Comment on attachment 8728184 [details]
MozReview Request: Bug 1249783 - remove ability to disable suggested sites (r=margaret)

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38837/diff/3-4/

Comment 16

[:Grisha Kruglov]

My apologies, Wes; I've tripped up a linter. Pushed up a fix ^

Comment 17

[:Grisha Kruglov]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a94144791a5a

Comment 18

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/612013e2676d

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/612013e2676d

Comment 20

[Teodora Vermesan (:TeoVermesan)]

Attachment: 12833195_10153401938806720_726230412_n.jpg

Verified as fixed using:
Device: One A2001 (Android 5.1.1) 
Build: Firefox for Android 48.0a1 (2016-03-13)