1010529 - [Buri] Greek letter "κ" looks like English letter 'k' at gaia in some cases

Status: RESOLVED WORKSFORME

(Core Graveyard :: Widget: Gonk, defect)

Description

[Alfredos-Panagiotis Damkalis [:fredy]]

I noticed this regression (check "see also" field) in screenshots of l10n testing in buri devices.

Unfortunately I don't have one to reproduce and in keon device font looks ok.

Please check screenshot in bug 1009222, where on the blue background the word "εκκαθάριση" looks like "εkkαθάριση" and in bug 1010373 where on the gray backgrounds the word "Προσθήκη" looks like "Προσθήkη".

Comment 1

[Jonathan Kew [:jfkthame]]

It looks like those devices include an incorrect version of at least one of the faces (Bold?) of Fira Sans. To confirm what's happening, it would be helpful to get a listing of the exact contents of the /system/fonts folder there (e.g. the result of running "adb shell ls -l /system/fonts"), to compare with the expected set of fonts.

Then I guess we'd need to find out more about the builds they're running, to see how this happened.

Comment 2

[Jason Smith [:jsmith]]

QA Wanted to address comment 1.

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Here is the list of files when using the command in comment 1.

-rw-r--r-- root     root         4824 2013-12-19 01:14 AndroidClock.ttf
-rw-r--r-- root     root         4824 2013-12-19 01:14 AndroidClock_Highlight.ttf
-rw-r--r-- root     root         4824 2013-12-19 01:14 AndroidClock_Solid.ttf
-rw-r--r-- root     root      1676072 2013-12-19 01:14 CharisSILCompact-B.ttf
-rw-r--r-- root     root      1667812 2013-12-19 01:14 CharisSILCompact-BI.ttf
-rw-r--r-- root     root      1693988 2013-12-19 01:14 CharisSILCompact-I.ttf
-rw-r--r-- root     root      1727656 2013-12-19 01:14 CharisSILCompact-R.ttf
-rw-r--r-- root     root         6880 2013-12-19 01:14 Clockopia.ttf
-rw-r--r-- root     root       366760 2013-12-19 01:14 DroidNaskh-Regular.ttf
lrw-r--r-- root     root              2013-12-19 01:17 DroidSans-Bold.ttf -> Roboto-Bold.ttf
lrw-r--r-- root     root              2013-12-19 01:17 DroidSans.ttf -> Roboto-Regular.ttf
-rw-r--r-- root     root        13856 2013-12-19 01:14 DroidSansArmenian.ttf
-rw-r--r-- root     root       227928 2013-12-19 01:17 DroidSansEthiopic-Regular.ttf
-rw-r--r-- root     root      5300184 2013-12-19 01:20 DroidSansFallback.ttf
-rw-r--r-- root     root        21096 2013-12-19 01:14 DroidSansGeorgian.ttf
-rw-r--r-- root     root        30280 2013-12-19 01:14 DroidSansHebrew-Bold.ttf
-rw-r--r-- root     root        30024 2013-12-19 01:14 DroidSansHebrew-Regular.ttf
-rw-r--r-- root     root       119380 2013-12-19 01:14 DroidSansMono.ttf
-rw-r--r-- root     root        35584 2013-12-19 01:14 DroidSansThai.ttf
-rw-r--r-- root     root       185228 2013-12-19 01:14 DroidSerif-Bold.ttf
-rw-r--r-- root     root       190304 2013-12-19 01:14 DroidSerif-BoldItalic.ttf
-rw-r--r-- root     root       177560 2013-12-19 01:14 DroidSerif-Italic.ttf
-rw-r--r-- root     root       172916 2013-12-19 01:14 DroidSerif-Regular.ttf
-rw-r--r-- root     root        71748 2013-12-19 01:14 FiraMonoOT-Bold.otf
-rw-r--r-- root     root        68848 2013-12-19 01:14 FiraMonoOT-Regular.otf
-rw-r--r-- root     root       113432 2013-12-19 01:14 FiraSansOT-Bold.otf
-rw-r--r-- root     root       116844 2013-12-19 01:14 FiraSansOT-BoldItalic.otf
-rw-r--r-- root     root       109364 2013-12-19 01:14 FiraSansOT-Light.otf
-rw-r--r-- root     root       112544 2013-12-19 01:14 FiraSansOT-LightItalic.otf
-rw-r--r-- root     root       112860 2013-12-19 01:14 FiraSansOT-Medium.otf
-rw-r--r-- root     root       115896 2013-12-19 01:14 FiraSansOT-MediumItalic.otf
-rw-r--r-- root     root       110244 2013-12-19 01:14 FiraSansOT-Regular.otf
-rw-r--r-- root     root       112660 2013-12-19 01:14 FiraSansOT-RegularItalic.otf
-rw-r--r-- root     root       139448 2013-12-19 01:17 Lohit-Bengali.ttf
-rw-r--r-- root     root        69000 2013-12-19 01:20 Lohit-Devanagari.ttf
-rw-r--r-- root     root        60572 2013-12-19 01:14 Lohit-Gujarati.ttf
-rw-r--r-- root     root       197872 2013-12-19 01:14 Lohit-Kannada.ttf
-rw-r--r-- root     root        69248 2013-12-19 01:14 Lohit-Malayalam.ttf
-rw-r--r-- root     root        97912 2013-12-19 01:14 Lohit-Oriya.ttf
-rw-r--r-- root     root        23912 2013-12-19 01:14 Lohit-Punjabi.ttf
-rw-r--r-- root     root        62248 2013-12-19 01:17 Lohit-Tamil.ttf
-rw-r--r-- root     root       170776 2013-12-19 01:14 Lohit-Telugu.ttf
-rw-r--r-- root     root      1924864 2013-12-19 01:14 MTLc3m.ttf
-rw-r--r-- root     root      2871020 2013-12-19 01:14 MTLmr3m.ttf
-rw-r--r-- root     root       443268 2013-12-19 01:14 Padauk-bold.ttf
-rw-r--r-- root     root       472488 2013-12-19 01:14 Padauk.ttf
-rw-r--r-- root     root       164936 2013-12-19 01:14 Roboto-Black.ttf
-rw-r--r-- root     root       166320 2013-12-19 01:14 Roboto-BlackItalic.ttf
-rw-r--r-- root     root        79620 2013-12-19 01:14 Roboto-Bold.ttf
-rw-r--r-- root     root       161308 2013-12-19 01:14 Roboto-BoldCondensed.ttf
-rw-r--r-- root     root       163584 2013-12-19 01:14 Roboto-BoldCondensedItalic.ttf
-rw-r--r-- root     root        82880 2013-12-19 01:14 Roboto-BoldItalic.ttf
-rw-r--r-- root     root       158284 2013-12-19 01:14 Roboto-Condensed.ttf
-rw-r--r-- root     root       161792 2013-12-19 01:14 Roboto-CondensedItalic.ttf
-rw-r--r-- root     root        82580 2013-12-19 01:14 Roboto-Italic.ttf
-rw-r--r-- root     root       162636 2013-12-19 01:14 Roboto-Light.ttf
-rw-r--r-- root     root       163248 2013-12-19 01:14 Roboto-LightItalic.ttf
-rw-r--r-- root     root       160696 2013-12-19 01:14 Roboto-Medium.ttf
-rw-r--r-- root     root       163940 2013-12-19 01:14 Roboto-MediumItalic.ttf
-rw-r--r-- root     root        79396 2013-12-19 01:14 Roboto-Regular.ttf
-rw-r--r-- root     root       122512 2013-12-19 01:14 Roboto-Thin.ttf
-rw-r--r-- root     root       125884 2013-12-19 01:14 Roboto-ThinItalic.ttf

Comment 4

[Jonathan Kew [:jfkthame]]

OK, the file sizes of the FiraSans fonts there confirm that this device has an old version - specifically, they match the files found in moztt *before* bug 928026 was merged (https://github.com/mozilla-b2g/moztt/pull/20).

According to bug 928026 comment 50, this should have been fixed, and AFAICS what's currently in the moztt repository is correct. So I think we need someone to look into the build configuration that was used for this device and figure out why it's getting an old version of the fonts.

Comment 5

[Michael Wu [:mwu]]

What base build is on this device?

Comment 6

[Alfredos-Panagiotis Damkalis [:fredy]]

Michael it is not my build, so I don't know. I copy here some info from the bugs 1009222 and 1010373 that may help:

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140514000204
Gaia: b40103dec34a147c9018a1af76eb21c3184f2f93
Gecko: 7788969f70b0
Version: 30.0
Firmware Version: v1.2-device.cfg

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140512000204
Gaia: 17fb44880e95bc7ae363a609d811bf5a9a067b5b
Gecko: ec24f847e7c0
Version: 30.0
Firmware Version: v1.2-device.cfg

Comment 7

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: 1.4 Greek Issue Screenshot

Issue is reproducible on today's 1.4, but NOT reproducible on today's master. Buri Tinderbox builds will be used to find the regression window.

Also attaching a screenshot from 1.4 in Contacts app demonstrating the issue.

Comment 8

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: Master 1.3 'working' build still exhibits the issue

This issue occurs on the following builds:
Today's 1.4, today's 1.3, earliest Tinderbox b2g30 (4/22), earliest Tinderbox 1.4 Aurora (3/17), earliest Central 1.4 build (12/12/2013)

Therefore the window was eventually found using master 1.3 nightly/RIL builds.

Nightly/RIL Regression Window:

Last Working Environmental Variables:
Device: Buri MOZ
BuildID: 20130924040201
Gaia: a22ba4a3a9efd99f94adf9ece8a2b391d4df295b
Gecko: 1fda74e33e06
Version: 27.0a1
Firmware Version: v1.2-device.cfg

First Broken Environmental Variables:
Device: Buri MOZ
BuildID: 20130925174530
Gaia: 7e42b4d690049709c62e8783910f16ab20869f42
Gecko: fa0e6916f88c
Version: 27.0a1
Firmware Version: v1.2-device.cfg

Last Working Gaia / First Broken Gecko: Issue DOES reproduce
Gaia: a22ba4a3a9efd99f94adf9ece8a2b391d4df295b
Gecko: fa0e6916f88c

Last Working Gecko / First Broken Gaia: Issue does NOT reproduce
Gaia: 7e42b4d690049709c62e8783910f16ab20869f42
Gecko: 1fda74e33e06

Gecko Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1fda74e33e06&tochange=fa0e6916f88c

Note:
1) Please also compare the screenshot I attached here, which I took from Last Working build, that it still exhibits the issue, but it shows the issue on DIFFERENT fields (title and add portrait box). On 1.4 where this issue was originally bugged under, does NOT exhibit the issue specifically on title and portrait box. Compare the screenshot on comment 7.

In short I think this word was never fully localized in all fields.

2) Bug 1009222 does NOT occur in my Last Working build.

Comment 9

[Jason Smith [:jsmith]]

If that's the window, then bug 919845 would be the cause, but that's been around since 1.1 HD.

Comment 10

[Pi Wei Cheng [:piwei] (inactive)]

Or, since this is fixed in today's master, I could also find out what fixed it, if you'd like.

Comment 11

[Jonathan Kew [:jfkthame]]

(In reply to Pi Wei Cheng from comment #8)
> Gecko Pushlog:
> http://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=1fda74e33e06&tochange=fa0e6916f88c

I assume the behavior changed during this Gecko window because of bug 919845, but this doesn't explain why these builds are getting an old version of the Fira fonts.

The "bad" Greek letters were removed from the Fira fonts in bug 928026. That fix should have ended up in 1.3 and later, AIUI. My question is, why aren't we getting the correct fonts in the Buri builds?

:mwu, any idea what could be wrong here?

Comment 12

[Axel Hecht [:Pike]]

Pi, how are you getting builds on the device?

Notably, I don't expect that a "flash gecko&gaia" update actually changes the fonts on the device, we'll need to reflash the gonk level (no idea how to actually do that my self)

Comment 13

[Pi Wei Cheng [:piwei] (inactive)]

(In reply to Axel Hecht [:Pike] from comment #12)
> Pi, how are you getting builds on the device?

We flash gecko and gaia on top of "v1.2-device.cfg" gonk/firmware on Buri.

Comment 14

[Jason Smith [:jsmith]]

Can we try testing this on Open C? The gonk fix should be included on Open C, so we should be able to see this issue fixed there.

Comment 15

[Harvey]

This issue does NOT reproduce on the latest Open_C 1.4

Environmental Variables:
Device: Open_C 1.4
BuildID: 20140519123002
Gaia: 6e1bacba06faf8803d4ff4b4d75b255526309904
Gecko: f863d35e8d71
Version: 30.0
Firmware Version: P821A10V1.0.0B06_LOG_DL

Comment 16

[Jason Smith [:jsmith]]

Since this is a Gonk only fix, I think this fix can be only see on builds with a gonk with the bug fix suggested above. On that regard, comment 15 proves this, so I'm closing this out.

Comment 17

[Panos Astithas (he/him) [:past] (please ni?)]

I assume that the Alcatel OneTouch Fire updates to 1.3 in Greece will come as FOTA, not OTA whenever they come out, right? Do we need to communicate this to TCL?

Comment 18

[Jason Smith [:jsmith]]

(In reply to Panos Astithas [:past] from comment #17)
> I assume that the Alcatel OneTouch Fire updates to 1.3 in Greece will come
> as FOTA, not OTA whenever they come out, right? Do we need to communicate
> this to TCL?

Should be FOTA - I don't think we need to outreach here, as this should happen just via the update process.