1010563 - Create post-push hook to print cset url for QA repositories on hg.mozilla.org

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This request is for: http://hg.mozilla.org/qa

What we want is an output as when landing patches on mozilla-central or other integration branches. Specifically the changeset URL included in the message like:

remote: You can view your change at the following URL:
remote:   https://hg.mozilla.org/build/puppet/rev/3eb84c83c047

Talked with Hal and Philor on IRC, and I will come up with a patch.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1

This adds our frequently used hg repositories to the printurls hook.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Looks like the addition for puppet is really necessary here. Otherwise when you push the original repository is shown:

pushing to ssh://hg.mozilla.org/qa/puppet
searching for changes
[..]
remote: You can view your change at the following URL:
remote:   https://hg.mozilla.org/build/puppet/rev/4709ac79bf99

Comment 3

[hwine]

Comment on attachment 8422761 [details] [diff] [review]
Patch v1

Review of attachment 8422761 [details] [diff] [review]:
-----------------------------------------------------------------

Won't work as is -- a few options I can think of:
 - remove the puppet mapping for now, while a longer term solution worked out
 - tweak the hook code to (a) always print URL & (b) do the right thing when no explicit mapping is available.

Offhand, I can't see an issue with the hook tweak, but some verification of it would need to be done, and the reason for the current hook uncovered (it seems like a lot of work to avoid printing a URL for all repos -- there must have been something that broke at the time of writing -- and that was only 2 years ago.) Adding :Callek for his memory & opinion.

::: mozhghooks/push_printurls.py
@@ +55,5 @@
>  
> +# QA repos
> +hgNameToRevURL.update({
> +    'mozmill-tests':        'qa/mozmill-tests',
> +    'puppet':               'qa/puppet',

This won't ever work for "puppet", as the update to the dictionary for the releng repos below will discard this setting. Worse, you'll get a URL to the wrong repository (i.e. to build/puppet instead of qa/puppet).

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 8422761 [details] [diff] [review]
Patch v1

Review of attachment 8422761 [details] [diff] [review]:
-----------------------------------------------------------------

Sadly I don't recall of any strong reason for the current design.

I vaguely recall it had to do with only getting the leaf name not the full path (and/or not wanting to hardcode path assumptions/values in here)

That said, if we have a requirement for qa/puppet and build/puppet we have this as a strong need to fix.

So this patch, minus puppet and deployed to all but qa/puppet would be what we need

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v2

Ok, so there the updated patch with the qa/puppet fork removed. I will file a new bug, so the underlying issue can be addressed.

Comment 6

[hwine]

Comment on attachment 8424185 [details] [diff] [review]
Patch v2

lgtm

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

https://hg.mozilla.org/hgcustom/hghooks/rev/b8bb1b75f072

Hal, is there anything else I have to do, or can this bug be closed now?

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Hal, we made a mistake here by forgetting about the final slashes for the repo values. But given that not only our newly added QA repositories are affected but also the project branches, I will file a new bug for getting this fixed.