Closed
Bug 1016801
Opened 12 years ago
Closed 12 years ago
Fix missing trailing slashes for repositories in push_printurls.py
Categories
(Developer Services :: Mercurial: hg.mozilla.org, defect)
Developer Services
Mercurial: hg.mozilla.org
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
Attachments
(1 file)
|
2.05 KB,
patch
|
hwine
:
review+
|
Details | Diff | Splinter Review |
In bug 1010563 I have added our QA related repositories to the printurls post-push hook. Sadly I missed the final slashes for the repository path, so the changeset as printed looks like:
https://hg.mozilla.org/qa/testcase-datarev/fe81a166e5b0
Interestingly I have taken the style from the project branches, which are listed above and are broken too. So lets get them fixed all at once.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8429812 -
Flags: review?(hwine)
Comment on attachment 8429812 [details] [diff] [review]
Final slashes v1
Review of attachment 8429812 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm - thanks!
Attachment #8429812 -
Flags: review?(hwine) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/hgcustom/hghooks/rev/1d448b7b8187
I will file a follow-up bug to get it deployed.
|
|
Assignee | |
Comment 4•12 years ago
|
||
Deployed via bug 1018889.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•12 years ago
|
||
Tested with testcase-data and it looks fine for me:
remote: You can view your change at the following URL:
remote: https://hg.mozilla.org/qa/testcase-data/rev/8bf6fa05e09d
Status: RESOLVED → VERIFIED
|
||
Updated•12 years ago
|
Product: Release Engineering → Developer Services
You need to log in
before you can comment on or make changes to this bug.
Description
•