1010668 - B2G NFC: Nfc doesn't implement nsIObserver

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

05-14 05:14:36.713: E/GeckoConsole(177): While creating services from category 'profile-after-change', service for entry 'Nfc', contract ID '@mozilla.org/nfc;1' does not implement nsIObserver.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

Comment 2

[Dimi Lee [ooo 16.04 - 21.04］]

Comment on attachment 8422903 [details] [diff] [review]
Patch

Review of attachment 8422903 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/Nfc.js
@@ +640,5 @@
> +   * nsIObserver interface methods.
> +   */
> +  observe: function(subject, topic, data) {
> +    if (aTopic != "profile-after-change") {
> +      if (DEBUG) {

We don't need DEBUG check here

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: 0001-Bug-1010668-B2G-NFC-Nfc-doesn-t-implement-nsIObserve.patch

removed DEBUG flag and fixed typo.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/df44342e527e

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/df44342e527e