Closed
Bug 1010714
Opened 12 years ago
Closed 12 years ago
From field doesnt have the same padding as to/cc/bcc/subject
Categories
(Thunderbird :: Theme, defect)
Tracking
(thunderbird31 fixed)
RESOLVED
FIXED
Thunderbird 32.0
| Tracking | Status | |
|---|---|---|
| thunderbird31 | --- | fixed |
People
(Reporter: gaston, Assigned: jsbruner)
References
Details
Attachments
(2 files, 1 obsolete file)
|
77.28 KB,
image/png
|
Details | |
|
758 bytes,
patch
|
jsbruner
:
review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
After bug 906264, and per comment 28 there - attaching a screenshot
| Reporter | ||
Comment 1•12 years ago
|
||
I suppose the fact that addresses not in the addressbook being shown in scary red is on purpose ?
| Reporter | ||
Comment 2•12 years ago
|
||
Oh and this is with 30.0b1 on OpenBSD/amd64.
Version: unspecified → 30
| Reporter | ||
Comment 3•12 years ago
|
||
And for the record, this was already shown in https://bug906264.bugzilla.mozilla.org/attachment.cgi?id=8347456
| Assignee | ||
Comment 4•12 years ago
|
||
Thanks, I'll look at this...
Assignee: nobody → josiah
Status: NEW → ASSIGNED
| Assignee | ||
Comment 5•12 years ago
|
||
Easy enough fix (Just had to get a new VM).
Attachment #8425825 -
Flags: review?(richard.marti)
Comment 6•12 years ago
|
||
Comment on attachment 8425825 [details] [diff] [review]
Fix
r+ with using -moz-padding-start instead of padding-left.
Attachment #8425825 -
Flags: review?(richard.marti) → review+
| Assignee | ||
Comment 7•12 years ago
|
||
Thanks.
Attachment #8425825 -
Attachment is obsolete: true
Attachment #8426529 -
Flags: review+
| Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
| Reporter | ||
Comment 8•12 years ago
|
||
Keywords: checkin-needed
| Reporter | ||
Comment 9•12 years ago
|
||
Comment on attachment 8426529 [details] [diff] [review]
Patch.
since 906264 had [ux-feature-wanted-31] in the whiteboard, lets try to push this to aurora...
[Approval Request Comment]
Regression caused by (bug #): 906264
User impact if declined: visual inconsistency on linux/unix/gtk platforms.
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): generating another inconsistency ? :)
Attachment #8426529 -
Flags: approval-comm-aurora?
Updated•12 years ago
|
Attachment #8426529 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 32.0
Comment 10•12 years ago
|
||
status-thunderbird31:
--- → fixed
| Assignee | ||
Updated•11 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•