Closed Bug 1010841 Opened 6 years ago Closed 6 years ago

[B2G][WebRTC] Handle on-demand key frame request in OMX H.264 encoder.

Categories

(Core :: WebRTC: Audio/Video, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32
feature-b2g 2.0

People

(Reporter: jhlin, Assigned: jhlin)

References

Details

Attachments

(1 file, 1 obsolete file)

Request IDR frame from OMX when WebRTC ask for key frame.
Tried several video calls but haven't seen any key request.
I've verified that requestIDRFrame() does work (i.e., will get I-frame after the call when disabling periodic I-frames).
Attachment #8423094 - Flags: feedback?(rjesup)
Status: NEW → ASSIGNED
Comment on attachment 8423094 [details] [diff] [review]
Ask for IDR frame from OMX encoder when key frame requested.

Review of attachment 8423094 [details] [diff] [review]:
-----------------------------------------------------------------

This should be good; if we're not seeing requests that's another issue.  Note that except maybe for the first frame (and probably not even there) a self one-way call would see no loss and no requests for iframes unless you artificially induce loss.
Attachment #8423094 - Flags: feedback?(rjesup) → review+
Update commit message & carry r+ from jesup.
Attachment #8423094 - Attachment is obsolete: true
Attachment #8423754 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/5b936e5fcacf
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
feature-b2g: --- → 2.0
You need to log in before you can comment on or make changes to this bug.