1010841 - [B2G][WebRTC] Handle on-demand key frame request in OMX H.264 encoder.

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[John Lin [:jhlin][:jolin]]

Request IDR frame from OMX when WebRTC ask for key frame.

Comment 1

[John Lin [:jhlin][:jolin]]

Attachment: Ask for IDR frame from OMX encoder when key frame requested.

Tried several video calls but haven't seen any key request.
I've verified that requestIDRFrame() does work (i.e., will get I-frame after the call when disabling periodic I-frames).

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8423094 [details] [diff] [review]
Ask for IDR frame from OMX encoder when key frame requested.

Review of attachment 8423094 [details] [diff] [review]:
-----------------------------------------------------------------

This should be good; if we're not seeing requests that's another issue.  Note that except maybe for the first frame (and probably not even there) a self one-way call would see no loss and no requests for iframes unless you artificially induce loss.

Comment 3

[John Lin [:jhlin][:jolin]]

Attachment: Bug-1010841-handle-key-frame-req.patch

Update commit message & carry r+ from jesup.

Comment 4

[John Lin [:jhlin][:jolin]]

Try result: https://tbpl.mozilla.org/?tree=Try&rev=5fa1a10d160f

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5b936e5fcacf

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5b936e5fcacf

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5b936e5fcacf