1010976 - Hitting the "Hide Controls" option twice causes the container area to disappear

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[Petruta Horea [:phorea], Desktop QA]

Reproduced on:
Firefox 30 beta 4 - 20140512231802
Mozilla/5.0 (X11; Linux i686; rv:30.0) Gecko/20100101 Firefox/30.0
latest Aurora 31.0a2 - 20140515004001
Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Firefox/31.0
latest Nightly 32.0a1 - 
Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Firefox/31.0

Steps to reproduce:
1. Open Firefox
2. Open any of the following mp3, opus and ogg files:
http://www.texasbagpiper.com/soundclips/11%20-%20Track%2011.mp3
http://people.xiph.org/~giles/2012/opus/detodos.opus
http://upload.wikimedia.org/wikipedia/en/4/45/ACDC_-_Back_In_Black-sample.ogg
3. Right click on the audio controls and select Hide Controls - the controls are hidden, only the audio container is displayed
4. Right click and choose Show Controls - the controls are shown again
5. Select Hide Controls once more

Expected result:
The controls bar is hidden, same as step 3.

Actual result:
The control bars and the container are no longer visible on the screen, the contextual menu is the default one everywhere on the display.  There is no way to show the controls again, the tab must be reloaded.
The file continues to play until the end.

Notes: 
1. The issue also reproduces on Win 7/8 64-bit and Mac OSX 10.9.2
2. This issue is regressed by bug 704326:
Regression range:
Last good revision: 70de5e24d79b (2013-11-07)
First bad revision: f003c386c77a (2013-11-08)
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=70de5e24d79b&tochange=f003c386c77a

Comment 1

[Ben Craddock]

This would be fixed by my proposed changes for bug 1059726 (i.e. removing the hide controls context menu option from audio).  I noticed this behavior too, while playing around with that one.

Comment 2

[Lawrence Mandel [:lmandel] (use needinfo)]

I'm not sure whether this work belongs to the desktop or media team. Flagging for the Firefox backlog for triage.

Comment 3

[Ada [:adalucinet]]

Issue still reproducible with STR from comment 0 and 34 beta 10 (Build ID: 20141117202603) on Windows 7 64-bit, Windows 8 32-bit, Mac OS X 10.9.5 and Ubuntu 12.04 32-bit.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

This was fixed by bug 1222669.

Comment 5

[Camelia Badau [:cbadau], Desktop QA]

I've tested on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.11.1 using Firefox 48 Beta 2 (buildID:  	20160620091522) and the issue doesn't occur anymore; the bug is fixed by bug 1222669 (which is fixed on Firefox 48). 

Marking VERIFIED FIXED.