Closed
Bug 1010998
Opened 12 years ago
Closed 12 years ago
Create gaia-confirm web component
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(b2g-v2.0 fixed)
RESOLVED
FIXED
2.0 S2 (23may)
| Tracking | Status | |
|---|---|---|
| b2g-v2.0 | --- | fixed |
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Whiteboard: [p=2],[systemsfe])
Attachments
(1 external file)
The confirm component is a rather commonly used component and is found in a number of apps. It should not be too difficult, except that we need to make it work for all of our use-cases. It would be good to implement a web component for this in shared/elements.
Examples of implementation can be found here: http://buildingfirefoxos.com/building-blocks/confirm.html
|
||
Updated•12 years ago
|
Alias: gaia-confirm
No longer blocks: gaia-web-components
|
|
||
Updated•12 years ago
|
Blocks: gaia-confirm
|
Assignee | |
Comment 1•12 years ago
|
||
This would be useful for the homescreen work, so I am going to take it and see if we can do something simple.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Whiteboard: [p=2],[systemsfe]
Target Milestone: --- → 2.0 S2 (23may)
|
|
Assignee | |
Comment 2•12 years ago
|
||
I have something basic coming together for this quickly, but ideally I think this would nest the gaia_buttons component for the buttons here.
For that reason I am going to wait until bug 1010990 is resolved.
Depends on: 1010990
|
|
Assignee | |
Comment 3•12 years ago
|
||
work in progress.
|
|
Assignee | |
Comment 4•12 years ago
|
||
Comment on attachment 8425756 [details] [review]
Github pull request
Aranau - I think this is looking pretty good when utilzing your gaia-buttons element. Can you take a look? Thanks!
Attachment #8425756 -
Flags: review?(arnau)
|
|
Assignee | |
Comment 5•12 years ago
|
||
Comment on attachment 8425756 [details] [review]
Github pull request
Thanks for the review! I'm also going to add Amir as a reviewer for this one as he wants to use it in some apps that he is working on building.
Attachment #8425756 -
Flags: review?(amirn)
|
||
Comment 6•12 years ago
|
||
Comment on attachment 8425756 [details] [review]
Github pull request
Used it in the Collection app and it works perfect!
Attachment #8425756 -
Flags: review?(amirn) → review+
|
|
Assignee | |
Comment 7•12 years ago
|
||
Comment on attachment 8425756 [details] [review]
Github pull request
As Arnau has taken a look at this, and Amir has reviewed it, I'm ok with landing for now. (There is a likely chance that we will need to add some features in the future or tweak things which I am fine with)
Attachment #8425756 -
Flags: review?(arnau)
|
|
Assignee | |
Comment 8•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
||
Updated•12 years ago
|
status-b2g-v2.0:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•