1011101 - [Camera][Gecko] Enable auto focus moving callbacks by default

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Diego Marcos [:dmarcos]]

Now we have to pref in to have the feature enabled. We need to add in build/config/custom-prefs.js the following lines:

user_pref("camera.control.face_detection.enabled", true);
user_pref("camera.control.autofocus_moving_callback.enabled", true);

The feature should be now enabled by default with no extra configuration

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: bug1011101.patch, v1

Face detection was already turned on in bug999396, just auto focus remaining

Comment 2

[Dave Hylands [:dhylands]]

Comment on attachment 8423868 [details] [diff] [review]
bug1011101.patch, v1

Review of attachment 8423868 [details] [diff] [review]:
-----------------------------------------------------------------

looks good to me

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

try: https://tbpl.mozilla.org/?tree=Try&rev=f09de60f4a95

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

May ignore Windows failures, not related to this submission. Emulator failures are intermittant and also unrelated to camera.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/20caba757625

Comment 6

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/mozilla-central/rev/20caba757625