1011168 - settings rendering wifi list test is broken

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect, P1)

Description

[Hubert Figuiere [:hub]]

settings rendering wifi list test is broken.

run on hamachi |RUNS=1 APP=settings make test-perf|

You'll get a script timeout and no results for "settings > rendering WiFi list >"

This is a regression. It is caused by bug 993318

git bisect of gaia in master found as first bad:

commit 6ca9e882b9ad1faf15e058308a8feb3af08b95e6
Author: gasolin <[e-mail]>
Date:   Thu Apr 10 17:49:40 2014 +0800

    Bug 993318 - [Settings] build script improvement for load time
    
    - prompt to alameda 0.2

Merged in commit 4afcad984ec25595c8acb1eb2660e77615f9955a

Comment 1

[Hubert Figuiere [:hub]]

As for the breakage, it seems that

app.element('wifiSelector', function(err, wifiSubpanel) {
        wifiSubpanel.tap();
});

never produce anything visible in the UI.

Comment 2

[Hubert Figuiere [:hub]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19327

Comment 3

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Comment on attachment 8423961 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19327

I'm not a Settings peer and I don't know enough about integration tests; 2 good reasons to pass the review to Arthur.

Comment 4

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Comment on attachment 8423961 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19327

Evelyn is probably a better choice because Arthur is in PTO next week.

Comment 5

[Hubert Figuiere [:hub]]

Please be careful, the PR has TWO patches for TWO bugs (one blocking the other). This bug and bug 1011575. Thanks.

Comment 6

[Evelyn Hung]

Comment on attachment 8423961 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19327

The patch makes sense to me. Thanks for fixing it. :)

Comment 7

[Evelyn Hung]

merged into gaia-master:

https://github.com/mozilla-b2g/gaia/commit/966e7a9ca3a8b94f18c1f2c300e5ccd19250fc91